fix(fslib): handle float timestamps in convertToBigIntStats #6988
+63
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes RangeError when file timestamps contain fractional milliseconds. Uses Math.floor() to ensure integer conversion before BigInt. The convertToBigIntStats function was failing when stats contained non-integer timestamps (e.g., 1763746784088.47), throwing: 'RangeError: The number X cannot be converted to a BigInt because it is not an integer' This can occur when ZIP file entries have timestamps with floating-point precision, particularly in Yarn 6.0.0-rc.5 when building with Storybook.
arcanis
reviewed
Nov 24, 2025
Comment on lines
202
to
205
| bigintStats.atimeNs = bigintStats.atimeMs * BigInt(1e6); | ||
| bigintStats.mtimeNs = bigintStats.mtimeMs * BigInt(1e6); | ||
| bigintStats.ctimeNs = bigintStats.ctimeMs * BigInt(1e6); | ||
| bigintStats.birthtimeNs = bigintStats.birthtimeMs * BigInt(1e6); |
Member
There was a problem hiding this comment.
These also need to be updated, as otherwise we lose the millisecond precision. Something like this should work, I think:
bigintStats.atimeNs = bigintStats.atimeMs * BigInt(1e6) + BigInt(Math.floor((stats.atimeMs % 1) * 1e3)) * BigInt(1e3);
bigintStats.mtimeNs = bigintStats.mtimeMs * BigInt(1e6) + BigInt(Math.floor((stats.mtimeMs % 1) * 1e3)) * BigInt(1e3);
bigintStats.ctimeNs = bigintStats.ctimeMs * BigInt(1e6) + BigInt(Math.floor((stats.ctimeMs % 1) * 1e3)) * BigInt(1e3);
bigintStats.birthtimeNs = bigintStats.birthtimeMs * BigInt(1e6) + BigInt(Math.floor((stats.birthtimeMs % 1) * 1e3)) * BigInt(1e3);
Contributor
Author
There was a problem hiding this comment.
Updated - great suggestion 👍
Address review feedback from @arcanis to preserve the fractional part of floating-point timestamps when converting to nanoseconds. The fractional milliseconds (e.g., 0.47ms from 1763746784088.47) are now extracted and added as additional nanoseconds: - 0.47ms → 470μs → 470,000ns This ensures no precision is lost during the conversion process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes RangeError when converting floating-point timestamps to BigInt in the
convertToBigIntStatsfunction.Problem
The
convertToBigIntStats()function fails when file stats contain non-integer timestamps (e.g.,1763746784088.47), throwing:This occurs when ZIP file entries have timestamps with floating-point precision, particularly observed in Yarn 6.0.0-rc.5 when building with Storybook.
Solution
Use
Math.floor()to ensure integer values before BigInt conversion on line 194 ofpackages/yarnpkg-fslib/sources/statUtils.ts.Changes
BigInt(element)toBigInt(Math.floor(element))Testing
Related
This issue was discovered while running
yarn storybook buildwith Yarn 6.0.0-rc.5.