Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/src/dev-guide/components-core/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ The task will download, build, and install (within the build directory) the foll

| Library | Version/commit |
|-----------------------------------------------------------------------|----------------|
| [abseil-cpp](https://github.com/abseil/abseil-cpp) | 20230802.1 |
| [abseil-cpp](https://github.com/abseil/abseil-cpp) | 20250512.0 |
| [ANTLR](https://www.antlr.org) | v4.13.1 |
| [Catch2](https://github.com/catchorg/Catch2.git) | v2.13.7 |
| [date](https://github.com/HowardHinnant/date.git) | v3.0.1 |
Expand Down
4 changes: 2 additions & 2 deletions taskfiles/deps/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@ tasks:
- "-DCMAKE_CXX_STANDARD=20"
- "-DCMAKE_INSTALL_MESSAGE=LAZY"
LIB_NAME: "absl"
TARBALL_SHA256: "987ce98f02eefbaf930d6e38ab16aa05737234d7afbab2d5c4ea7adbe50c28ed"
TARBALL_URL: "https://github.com/abseil/abseil-cpp/archive/refs/tags/20230802.1.tar.gz"
TARBALL_SHA256: "7262daa7c1711406248c10f41026d685e88223bc92817d16fb93c19adb57f669"
TARBALL_URL: "https://github.com/abseil/abseil-cpp/archive/refs/tags/20250512.0.tar.gz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use the release tar instead of the auto-generated source tar ball? (https://github.com/abseil/abseil-cpp/releases/tag/20250512.0)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only because that's what we were doing here before. I can change it if the auto-generated source tar ball is preferred?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use https://github.com/abseil/abseil-cpp/releases/download/20250512.0/abseil-cpp-20250512.0.tar.gz since that would be the tar directly uploaded by the maintainer who created the release (so it should be what they intended to release rather than what GitHub automatically generated). In this case, they're identical, but for future releases, they may differ.


antlr-jar:
internal: true
Expand Down
Loading