-
Notifications
You must be signed in to change notification settings - Fork 88
build(deps-core): Bump abseil version from 20230802.1 to 20250512.0. #985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes update the Abseil C++ library dependency for the CLP core component, reflecting a new version number in both the developer documentation and the dependency configuration file. The associated URL and checksum for the new release are also updated. No other dependencies or configurations are altered. Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (6)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
taskfiles/deps/main.yaml
Outdated
| TARBALL_SHA256: "987ce98f02eefbaf930d6e38ab16aa05737234d7afbab2d5c4ea7adbe50c28ed" | ||
| TARBALL_URL: "https://github.com/abseil/abseil-cpp/archive/refs/tags/20230802.1.tar.gz" | ||
| TARBALL_SHA256: "7262daa7c1711406248c10f41026d685e88223bc92817d16fb93c19adb57f669" | ||
| TARBALL_URL: "https://github.com/abseil/abseil-cpp/archive/refs/tags/20250512.0.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use the release tar instead of the auto-generated source tar ball? (https://github.com/abseil/abseil-cpp/releases/tag/20250512.0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only because that's what we were doing here before. I can change it if the auto-generated source tar ball is preferred?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use https://github.com/abseil/abseil-cpp/releases/download/20250512.0/abseil-cpp-20250512.0.tar.gz since that would be the tar directly uploaded by the maintainer who created the release (so it should be what they intended to release rather than what GitHub automatically generated). In this case, they're identical, but for future releases, they may differ.
Description
This PR bumps abseil to the latest release version.
Checklist
breaking change.
Validation performed
Summary by CodeRabbit