-
Notifications
You must be signed in to change notification settings - Fork 83
feat(integration-tests): Test search with the CLP package. #1652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(integration-tests): Test search with the CLP package. #1652
Conversation
…ig file; address comments.
…er-level clp-config.yml
…E_CONFIGS other than clp-text and clp-json
…equired components.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…nning of fixture names.
…over between different modes during testing.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
This PR implements the code that enumerates and facilitates search test jobs that will be run on the CLP package.
Structure
Search jobs are described with the
PackageSearchJobdata class. They are enumerated inclp_job_utils.py. Jobs relevant to the current test run are assembled inPackageJobListfor eachPackageConfigobject by a central job list creator. After the relevant package is spun up, the listed jobs for that package run are dispatched fromdispatch_test_jobsintest_clp_package. Search jobs are run directly after the compression job on which they depend, to prevent searching on multiple compressed archives (archives are cleared after each compression job).All search jobs are run from
search_with_clp_package. Search success is verified by comparing against the ground truth stored in eachPackageSearchJobobject.Command syntax
Command syntax is identical to that introduced in #1651.
PR dependencies
This PR is built on top of the following PRs:
clp-textandclp-jsonpackages. #1437component_listdata member withinPackageConfig. #1658validate_package_running. #1659validate_running_mode_correct. #1660BASE_PORTto avoid package spin-up failure. #1662task tests:integration:packageto run all package integration tests. #1664Dependent PRs
This is a foundational infra PR, and so there are other PRs which depend on this one. They are listed below:
Checklist
breaking change.
Validation performed
Ran all permutations of possible user commands; all succeed.