Skip to content

Conversation

@quinntaylormitchell
Copy link
Collaborator

@quinntaylormitchell quinntaylormitchell commented Nov 23, 2025

Description

This PR implements the code that enumerates and facilitates search test jobs that will be run on the CLP package.

Structure

Search jobs are described with the PackageSearchJob data class. They are enumerated in clp_job_utils.py. Jobs relevant to the current test run are assembled in PackageJobList for each PackageConfig object by a central job list creator. After the relevant package is spun up, the listed jobs for that package run are dispatched from dispatch_test_jobs in test_clp_package. Search jobs are run directly after the compression job on which they depend, to prevent searching on multiple compressed archives (archives are cleared after each compression job).

All search jobs are run from search_with_clp_package. Search success is verified by comparing against the ground truth stored in each PackageSearchJob object.

Command syntax

Command syntax is identical to that introduced in #1651.

PR dependencies

This PR is built on top of the following PRs:

Dependent PRs

This is a foundational infra PR, and so there are other PRs which depend on this one. They are listed below:

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

Ran all permutations of possible user commands; all succeed.

quinntaylormitchell and others added 24 commits November 20, 2025 00:43
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…over between different modes during testing.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 23, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants