-
Notifications
You must be signed in to change notification settings - Fork 83
feat(integration-tests): Assign ports based on BASE_PORT to avoid package spin-up failure.
#1662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(integration-tests): Assign ports based on BASE_PORT to avoid package spin-up failure.
#1662
Conversation
…ig file; address comments.
…er-level clp-config.yml
…E_CONFIGS other than clp-text and clp-json
…equired components.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…nning of fixture names.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
This PR adds a system that assigns each component of the clp package a port based off of
BASE_PORT, which is defined in.pytest.ini(default55000). The intent is to avoid most port conflicts by assigning ports in the dynamic range. If there is still a port conflict on spin-up, the user will be prompted to select a different value forBASE_PORT.PR dependencies
This PR depends on the following being merged:
clp-textandclp-jsonpackages. #1437Checklist
breaking change.
Validation performed
Ran the following command from
clp/integration-tests:uv run pyetst -m 'package'Both the
clp-jsonandclp-texttests passed.