Skip to content

Conversation

@surli
Copy link
Member

@surli surli commented Nov 18, 2024

Jira URL

https://jira.xwiki.org/browse/XWIKI-22571

Changes

Description

  • Use default serializer if the wiki is present in a link, not the compact serializer
  • Provide unit test and integration test to cover this

Clarifications

  • Right now the oracle to guess if the link contains a wiki is by using a regex, but I'm not very happy with this, we should probably find a better way for detecting it.

Screenshots & Video

Executed Tests

Run tests in modules:

  • xwiki-platform-flamingo-skin-test-docker:
    •  2 failures to fix in DeletePageIT
  • xwiki-platform-refactoring-default

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • 16.10.x only

…ved page into one relative to the current wiki

  * Use default serializer if the wiki is present in a link, not the
    compact serializer
  * Provide unit test and integration test to cover this
…ved page into one relative to the current wiki

  * Fix DeletePageIT tests
…ved page into one relative to the current wiki

  * simplify condition by using the relative resource reference resolver
…ved page into one relative to the current wiki

  * fix tests
@surli surli marked this pull request as ready for review December 10, 2024 14:47
@surli surli merged commit d2d9a57 into master Dec 10, 2024
1 check passed
@surli surli deleted the XWIKI-22571 branch December 10, 2024 14:48
github-actions bot pushed a commit that referenced this pull request Dec 10, 2024
…ved page into one relative to the current wiki (#3654)

  * Use default serializer if the wiki is present in a link, not the
    compact serializer
  * Provide unit test and integration test to cover this
  * Fix DeletePageIT tests
  * simplify condition by using the relative resource reference resolver
  * fix tests

(cherry picked from commit d2d9a57)
surli added a commit that referenced this pull request Dec 10, 2024
…ved page into one relative to the current wiki (#3654)

  * Use default serializer if the wiki is present in a link, not the
    compact serializer
  * Provide unit test and integration test to cover this
  * Fix DeletePageIT tests
  * simplify condition by using the relative resource reference resolver
  * fix tests

(cherry picked from commit d2d9a57)
surli added a commit that referenced this pull request Feb 26, 2025
…ved page into one relative to the current wiki (#3654)

  * Use default serializer if the wiki is present in a link, not the
    compact serializer
  * Provide unit test and integration test to cover this
  * Fix DeletePageIT tests
  * simplify condition by using the relative resource reference resolver
  * fix tests

(cherry picked from commit d2d9a57)
earzur pushed a commit to earzur/xwiki-platform that referenced this pull request Sep 8, 2025
…ved page into one relative to the current wiki (xwiki#3654)

  * Use default serializer if the wiki is present in a link, not the
    compact serializer
  * Provide unit test and integration test to cover this
  * Fix DeletePageIT tests
  * simplify condition by using the relative resource reference resolver
  * fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants