XWIKI-22571: Backlinks update changes an absolute reference to the moved page into one relative to the current wiki

  * simplify condition by using the relative resource reference resolver

Author: surli

xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/ResourceReferenceRenamer.java

@@ -59,6 +59,10 @@ public class ResourceReferenceRenamer
     @Inject
     private EntityReferenceResolver<ResourceReference> entityReferenceResolver;
 
+    @Inject
+    @Named("relative")
+    private EntityReferenceResolver<ResourceReference> relativeEntityReferenceResolver;
+
     @Inject
     @Named("compact")
     private EntityReferenceSerializer<String> compactEntityReferenceSerializer;
@@ -206,9 +210,10 @@ private boolean updateAbsoluteResourceReference(ResourceReference resourceRefere
     private String getNewTargetReference(ResourceReference resourceReference, EntityReference newTargetReference,
         EntityReference currentReference)
     {
+        EntityReference entityReference =
+            this.relativeEntityReferenceResolver.resolve(resourceReference, null, (Object) null);
         // If the reference contains the wiki name, then we should keep the absolute serialization.
-        // TODO: This regex feels really fragile, I'm not sure how we should check presence of a wiki here.
-        if (resourceReference.getReference().matches("^\\w+:\\w.*$")) {
+        if (entityReference.extractReference(EntityType.WIKI) != null) {
             return this.defaultEntityReferenceSerializer.serialize(newTargetReference, currentReference);
         } else {
             return this.compactEntityReferenceSerializer.serialize(newTargetReference, currentReference);