Create Terminado guide #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parisk
suggested changes
Oct 8, 2016
_docs/guides/terminado.md
Outdated
|
|
||
| ## Terminado communications protocol | ||
|
|
||
| The difference between the `terminadoAttach()` function provided by the `terminado` plugin and the `attach()` function provided by the `attach` plugin are minor. `Terminado` simply requires messages declare the type of data they carry by sending (for example) `['stdin', stdin_data]` instead of `stdin_data` over the websockets. The differences between the two plugins can be easily seen by diff'ing the two plugins' javascript files in the `addons` directory of the `Xterm.js` repository. |
Contributor
There was a problem hiding this comment.
Can yo rename plugin to addon please?
Contributor
Author
There was a problem hiding this comment.
You'd think that the fact that I explicitly mention the addon directory would be enough to clue me in. ;)
Done.
takluyver
reviewed
Oct 17, 2016
_docs/guides/terminado.md
Outdated
| category: Guides | ||
| --- | ||
|
|
||
| Xterm.js can connect to backends other than the default node.js backend, as an example we will build a simple [Terminado](https://github.com/takluyver/terminado) application, and hook up to it with `Xterm.js`. `Terminado` is a python/twisted websocket host for terminal applications. |
There was a problem hiding this comment.
Nitpick: Terminado is based on the tornado async machinery, not twisted.
Contributor
There was a problem hiding this comment.
@staticfloat please resolve this comment and we should be ready to go 😊 .
parisk
approved these changes
Oct 17, 2016
Contributor
Author
|
Fixed and squashed. |
Contributor
|
Great. Thanks for this contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.