terminal: Bump xterm.js to 2.1.0

[yuvipanda]

Primary fix is better copy / paste support

Release notes in https://github.com/sourcelair/xterm.js/releases/tag/2.0.1

Doesn't seem to break any styling, unlike the last update I made :)

[takluyver]

XTerm now has a publicly documented API. So what are we using that's not in the documented API:

• Constructor options, but I think this is an omission from the docs - the source code looks like constructor options are supported. I'll open an issue on xterm about it.
• screenKeys and useStyle options - don't appear to be there in the code.
• brokenBold - still in the code, looks like it's now autodetected, so we shouldn't need to set it.
• The title event.

[Carreau]

XTerm now has a publicly documented API. So what are we using that's not in the documented API:

Constructor options, but I think this is an omission from the docs - the source code looks like constructor options are supported. I'll open an issue on xterm about it.
screenKeys and useStyle options - don't appear to be there in the code.
brokenBold - still in the code, looks like it's now autodetected, so we shouldn't need to set it.
The title event.

Is that a request for a change ? The app-veyor breakage is unrelated. Can we merge ?

[takluyver]

Yes, it's a request to clean up the things that are probably no longer needed or have no effect: screenKeys, useStyle and brokenBold.

I've opened an issue for the constructor options (xtermjs/xterm.js#313). The title event is still there in the xterm code, so let's leave that for now, and I'll open an issue about documenting it.

[takluyver]

Title event: xtermjs/xterm.js#315

[yuvipanda]

I'll patch these later in the day. Thanks for checking that, Thomas!

On Tue, Oct 18, 2016 at 4:04 AM, Thomas Kluyver [email protected]
wrote:

Title event: xtermjs/xterm.js#315
xtermjs/xterm.js#315

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1838 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAB23sK2reflhuvImCTUbftIdBLX1o_gks5q1KfDgaJpZM4KXx48
.

Yuvi Panda T
http://yuvi.in/blog

[rgbkrk]

I love that the docs show how to connect it up with terminado.

[takluyver]

Yup, that landed yesterday :-) xtermjs/xtermjs.org#4

[takluyver]

Ping @yuvipanda :-)

[yuvipanda]

Caught up with a bunch of other stuff. Tomorrow :)

On Tue, Oct 25, 2016 at 3:34 AM, Thomas Kluyver [email protected]
wrote:

Ping @yuvipanda https://github.com/yuvipanda :-)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1838 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAB23nJmGBCN8uS2eXkVVer4RnhrTw19ks5q3dtRgaJpZM4KXx48
.

Yuvi Panda T
http://yuvi.in/blog

[yuvipanda]

@takluyver I bumped xterm verion and also removed the deprecated constructor params. I'll also send a PR to xterm.js about the title event now.

[yuvipanda]

Should we consider switching to using https://github.com/sourcelair/xterm.js/blob/b1c6ae8a06ecef68a86a648beaaccf65fee056d8/addons/terminado/terminado.js directly?

[yuvipanda]

I can't seem to find where to send doc PRs to xterm.js

[takluyver]

https://github.com/xtermjs/docs.xtermjs.org ?

[takluyver]

This looks good to me, thanks :)

[yuvipanda]

xtermjs/xterm.js#351 for docs in xterm.js

[takluyver]

Nice one :-)