Fix cursor style on blurred terminals#603
Merged
Merged
Conversation
Tyriar
approved these changes
Mar 15, 2017
Member
Tyriar
left a comment
There was a problem hiding this comment.
Good catch, I verified the bug/fix locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #492 the hollow cursor style implemented in #82 broke. It displayed a filled cursor in blurred terminals, when no explicit cursor style was set (
underlineorbar).This PR applies the "generic" cursor styling only when the terminal is focused.
This means that a blurred terminal will always display a hollow "block" cursor from now on.
I think that this is the best experience possible in the blurred state, since it's the same for all cursor styles and it's quite hard to think of a way to apply "blurred" state on cursor styles that are just a line (
underlineorbar)