Skip to content

Implement CSI Ps SP q Set cursor style #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Tyriar merged 2 commits into from
Jan 20, 2017
Merged

Implement CSI Ps SP q Set cursor style #492

Tyriar merged 2 commits into from
Jan 20, 2017

Conversation

@Tyriar
Copy link
Member

@Tyriar Tyriar commented Jan 18, 2017

Fixes #480

cursor-styles

@Tyriar Tyriar self-assigned this Jan 18, 2017
@Tyriar Tyriar requested a review from parisk January 18, 2017 18:17
@Tyriar
Copy link
Member Author

Tyriar commented Jan 18, 2017

Testing is so easy now 9227aed

We just need to bring in phantomjs to make it even nicer!

parisk
parisk approved these changes Jan 20, 2017
View reviewed changes
Copy link
Contributor

@parisk parisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Tyriar Tyriar merged commit 6918e83 into xtermjs:master Jan 20, 2017
@Tyriar Tyriar deleted the 480_cursor_style branch January 20, 2017 15:26
@Tyriar Tyriar modified the milestone: 2.3.0 Feb 2, 2017
@parisk parisk mentioned this pull request Mar 15, 2017
Merged
@hyperpallium hyperpallium mentioned this pull request Oct 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@parisk parisk parisk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Tyriar Tyriar

Labels

None yet

Projects

None yet

Milestone

2.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Tyriar @parisk