Fixed copy event in IE11 #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parisk
reviewed
Nov 4, 2016
src/handlers/Clipboard.js
Outdated
| } | ||
|
|
||
| // Browser detection using the user agent | ||
| function detectBrowser(userAgent) { |
Contributor
There was a problem hiding this comment.
I am not sure if here is the right place for this as it is not a clipboard specific utility.
Let's leave this here though until we find a better place for it, but feel free to drop any other ideas.
Contributor
hiro-su
force-pushed
the
fix-ie11-copy-event
branch
3 times, most recently
from
ae2c2f3 to
9950394
Compare
hiro-su
force-pushed
the
fix-ie11-copy-event
branch
from
9950394 to
5808de6
Compare
Contributor
Author
|
@parisk Thank you for your suggestions! |
parisk
approved these changes
Nov 5, 2016
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello!,
an error occurs by the copy event in IE11.
problems similar to #334
this pr will fix it, so please check.