Fixed paste key in IE11 #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parisk
suggested changes
Nov 1, 2016
src/handlers/Clipboard.js
Outdated
| if (ev.clipboardData) { | ||
| var text = ev.clipboardData.getData('text/plain'); | ||
|
|
||
| var paste = function() { |
Contributor
There was a problem hiding this comment.
- Please add a
textargument to the function. - I would prefer it if the function was renamed to something more semantic like
dispatchPaste
src/handlers/Clipboard.js
Outdated
| if (userAgent.match(/msie|MSIE/) || userAgent.match(/(T|t)rident/)) { | ||
| if (window.clipboardData) { | ||
| var text = window.clipboardData.getData('Text'); | ||
| paste(); |
Contributor
There was a problem hiding this comment.
Please call this as paste(text).
src/handlers/Clipboard.js
Outdated
| } else { | ||
| if (ev.clipboardData) { | ||
| var text = ev.clipboardData.getData('text/plain'); | ||
| paste(); |
Contributor
There was a problem hiding this comment.
Please call this as paste(text).
Contributor
|
Thanks for this @hiro-su! Just a few code comments to be fixed and I think it's good to go. |
hiro-su
force-pushed
the
fix-ie11-paste-key
branch
from
20e7b92 to
77ca154
Compare
Contributor
Author
|
@parisk Thank you for review. I made some changes to pr. Can you be able to check them? |
parisk
approved these changes
Nov 2, 2016
Contributor
|
Great @hiro-su, thanks! |
Contributor
|
@hiro-su just letting you know that we mentioned you for this contribution (along with #339 and #345), in the 2.1 announcement. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello, i always use this project.
can't get data
ev.clipboardDatain IE11.this pr will fix it, so please check.