Force char size measurement when devicePixelRatio changes #3243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanp413
added a commit
to jeanp413/vscode
that referenced
this pull request
Feb 5, 2021
Depends on xtermjs/xterm.js#3243
This was referenced Feb 5, 2021
Tyriar
approved these changes
Feb 5, 2021
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
Looks good, seems safe as well since ICharSizeService.onCharSizeChange only fires if they do actually differ
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vscode#102194
Note that
this._charSizeService.measure()could trigger a call tothis._renderer.onCharSizeChanged()which uses the same logic asthis._renderer.onDevicePixelRatioChange()underneath