Merge pull request #3243 from jeanp413/measure-charsize-on-devicePixelRatioChange

Tyriar · web-flow · commit a73fe62b7aed · 2021-02-05T11:39:31.000-08:00
Force char size measurement when devicePixelRatio changes
diff --git a/src/browser/services/RenderService.ts b/src/browser/services/RenderService.ts
@@ -174,6 +174,10 @@ export class RenderService extends Disposable implements IRenderService {
   }
 
   public onDevicePixelRatioChange(): void {
+    // Force char size measurement as DomMeasureStrategy(getBoundingClientRect) is not stable
+    // when devicePixelRatio changes
+    this._charSizeService.measure();
+
     this._renderer.onDevicePixelRatioChange();
     this.refreshRows(0, this._rowCount - 1);
   }

Original file line number	Diff line number	Diff line change
`@@ -174,6 +174,10 @@ export class RenderService extends Disposable implements IRenderService {`
`174`	`174`	`}`
`175`	`175`
`176`	`176`	`public onDevicePixelRatioChange(): void {`
	`177`	`+ // Force char size measurement as DomMeasureStrategy(getBoundingClientRect) is not stable`
	`178`	`+ // when devicePixelRatio changes`
	`179`	`+ this._charSizeService.measure();`
	`180`	`+`
`177`	`181`	`this._renderer.onDevicePixelRatioChange();`
`178`	`182`	`this.refreshRows(0, this._rowCount - 1);`
`179`	`183`	`}`