This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Invalid transactionPollingTimeout compared to transactionPollingInterval
#5323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazarhussain
requested review from
Muhammad-Altabba,
avkos,
jdevcs,
luu-alex,
nikoulai and
spacesailor24
|
Your Render PR Server URL is https://web3js-docs-pr-5323.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cbng41qrrk0a9lu7c0k0. |
nazarhussain
force-pushed
the
nh/5320-polling-timeout
branch
from
dae8234 to
f89eccf
Compare
1 task
avkos
suggested changes
Aug 8, 2022
Contributor
avkos
left a comment
avkos
left a comment
There was a problem hiding this comment.
We have integration tests for default parameters. It will be great to fix them too.
jdevcs
reviewed
Aug 8, 2022
Contributor
jdevcs
left a comment
jdevcs
left a comment
There was a problem hiding this comment.
some tests are failing, needs to be fixed.
jdevcs
approved these changes
Aug 8, 2022
avkos
approved these changes
Aug 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5320
Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildwith success.dist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.