Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Invalid transactionPollingTimeout compared to transactionPollingInterval #5323

Merged
merged 4 commits into from
Aug 8, 2022
+4 −4
Merged

Invalid transactionPollingTimeout compared to transactionPollingInterval #5323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f89eccf
:bug: Fix transaciton pooling timeout
nazarhussain Aug 7, 2022
f42dfe6
Merge branch '4.x' into nh/5320-polling-timeout
jdevcs Aug 8, 2022
a032724
Merge branch '4.x' into nh/5320-polling-timeout
nazarhussain Aug 8, 2022
f415b01
:white_check_mark: Fix integration tests
nazarhussain Aug 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/web3-core/src/web3_config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export abstract class Web3Config
transactionBlockTimeout: 50,
transactionConfirmationBlocks: 24,
transactionPollingInterval: 1000,
transactionPollingTimeout: 750,
transactionPollingTimeout: 750 * 1000,
transactionReceiptPollingInterval: undefined,
transactionConfirmationPollingInterval: undefined,
blockHeaderTimeout: 10,
Expand Down
2 changes: 1 addition & 1 deletion packages/web3-core/test/unit/__snapshots__/web3_context.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Object {
"transactionConfirmationBlocks": 24,
"transactionConfirmationPollingInterval": undefined,
"transactionPollingInterval": 1000,
"transactionPollingTimeout": 750,
"transactionPollingTimeout": 750000,
"transactionReceiptPollingInterval": undefined,
"transactionTypeParser": undefined,
},
Expand Down
2 changes: 1 addition & 1 deletion packages/web3-core/test/unit/web3_config.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const defaultConfig = {
transactionBlockTimeout: 50,
transactionConfirmationBlocks: 24,
transactionPollingInterval: 1000,
transactionPollingTimeout: 750,
transactionPollingTimeout: 750 * 1000,
transactionReceiptPollingInterval: undefined,
transactionConfirmationPollingInterval: undefined,
defaultTransactionType: '0x0',
Expand Down
2 changes: 1 addition & 1 deletion packages/web3-eth/test/integration/defaults.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ describe('defaults', () => {
it('transactionPollingInterval and transactionPollingTimeout', () => {
// default
expect(web3Eth.transactionPollingInterval).toBe(1000);
expect(web3Eth.transactionPollingTimeout).toBe(750);
expect(web3Eth.transactionPollingTimeout).toBe(750 * 1000);

// after set
web3Eth.setConfig({
Expand Down