Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -505,6 +505,7 @@ Released with 1.0.0-beta.37 code base.
- Correction in documentation for `web3.eth.accounts.signTransaction` (#4576)
- Updated README to include Webpack 5 create-react-app support instructions (#4173)
- Update the documentation for `methods.myMethod.estimateGas` (#4702)
- Fix typos in REVIEW.md and TESTING.md (#4691)

### Changed
- Muted E2E gnosis dex tests in CI until fix for issue #4436 is applied (#4701)
Expand Down
4 changes: 2 additions & 2 deletions REVIEW.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Only published PRs will be considered for review. Draft PRs will be considered i
## Rules

* [ ] PR follows the provided [template](.github/PULL_REQUEST_TEMPLATE.md).
* [ ] PR doesn't contain unneccessary changes.
* [ ] PR doesn't contain unnecessary changes.
* [ ] The changed code preserves the conventions and stylistic consistency of the project.
* [ ] PR uses labels accordingly. (new labels may be suggested)
* [ ] PR includes unit and e2e tests if related to any logic changes.
Expand All @@ -20,7 +20,7 @@ Only published PRs will be considered for review. Draft PRs will be considered i
* [ ] Any new files contain the web3.js file header.
* [ ] The documentation was updated (if applicable).
* [ ] The CHANGELOG was updated accordingly.
* [ ] The CI with QA passes succesfully.
* [ ] The CI with QA passes successfully.
* [ ] The CI logs were manually checked to ensure false positives were not reported.
* [ ] All comments have been addressed.
* [ ] Doesn't add undue maintenance burden.
Expand Down
2 changes: 1 addition & 1 deletion TESTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ in their mocha test description and runs them against:
These tests are grouped in files prefixed by "e2e", ex: `test/e2e.method.call.js`.

Additionally, there are conventional unit tests postfixed `.ganache.js` which spin up a ganache
server programatically within mocha. This pattern is useful if you want to
server programmatically within mocha. This pattern is useful if you want to
control client configuration for a specific case, test against multiple independent providers, etc.

**"Real world" tests**
Expand Down