This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Fix typos in REVIEW.md and TESTING.md #4691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
REVIEW.md:10: unneccessary -> unnecessary REVIEW.md:23: succesfully -> successfully TESTING.md:55: programatically -> programmatically
Contributor
|
Hey! Thank you for this PR :) one last thing, can you update the changelog |
luu-alex
added
1.x
jdevcs
suggested changes
Jan 17, 2022
nazarhussain
approved these changes
Jan 18, 2022
luu-alex
approved these changes
Jan 19, 2022
jdevcs
approved these changes
Jan 19, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes typographical errors in markdown files
REVIEW.md:10: unneccessary -> unnecessary
REVIEW.md:23: succesfully -> successfully
TESTING.md:55: programatically -> programmatically
Type of change
Documentation - typofix
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.