Added translations for ca - Catalan #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughReplaces hard‑coded UI strings in the account activity feed with i18n lookups and adds extensive Catalan (ca) translations across models, views, Doorkeeper, and application locale files; also adds an English search placeholder key for the activity view. Changes
Sequence Diagram(s)(omitted — changes are localization additions and a string substitution in a view; no control‑flow or new runtime interactions to visualize) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
|
|
||
| <% if activity_dates.empty? %> | ||
| <p class="text-secondary text-sm p-4">No entries yet</p> | ||
| <%= tag.p t("accounts.show.activity.no_entries"), class: "text-secondary text-sm p-4" %> |
There was a problem hiding this comment.
Bug: Bulk Select Labels Lack Translation Support
Bulk select labels are hardcoded in English ("entry" and "entries") instead of using translation keys. While the PR adds Catalan translations for these labels (accounts.show.activity.entry and accounts.show.activity.entries), the activity feed component doesn't use them. These should be changed to:
- bulk_select_singular_label_value: t("accounts.show.activity.entry")
- bulk_select_plural_label_value: t("accounts.show.activity.entries")
This prevents the bulk select labels from being internationalized, breaking the multilingual support that this PR is intended to add.
jjmata
approved these changes
Oct 26, 2025
This was referenced Oct 28, 2025
Merged
TimesAgainst
pushed a commit
to Nova-Haven/sure-mod
that referenced
this pull request
Oct 28, 2025
commit 9fefe57 Author: João Felipe <[email protected]> Date: Wed Oct 29 02:15:14 2025 +0400 Feature/yahoo finance (we-promise#123) * Implement Yahoo Finance * Added tests * Updated hosting controller to check for managed app_mode instead of env_override * Suggestions from CodeRabbit and Fixes on tests * Remove Css changes * Fix yahoo finance impl and i18n * Updated view to use healthy method * remove usage * Updated env example * keep usage on class just to keep same format * Ci test * Remove some useless validations * Remove logs * Linter fixes * Broke this in my conflict merge * Wrong indentation level --------- Signed-off-by: Juan José Mata <[email protected]> Co-authored-by: Juan José Mata <[email protected]> commit 3910116 Author: Albert Solà <[email protected]> Date: Tue Oct 28 20:23:20 2025 +0000 Update pages/dashboard locales (we-promise#255) commit 4fb0a38 Author: soky srm <[email protected]> Date: Tue Oct 28 19:32:27 2025 +0100 Providers factory (we-promise#250) * Implement providers factory * Multiple providers sync support - Proper Multi-Provider Syncing: When you click sync on an account with multiple providers (e.g., both Plaid and SimpleFin), all provider items are synced - Better API: The existing account.providers method already returns all providers, and account.provider returns the first one for backward compatibility - Correct Holdings Deletion Logic: Holdings can only be deleted if ALL providers allow it, preventing accidental deletions that would be recreated on next sync TODO: validate this is the way we want to go? We would need to check holdings belong to which account, and then check provider allows deletion. More complex - Database Constraints: The existing validations ensure an account can have at most one provider of each type (one PlaidAccount, one SimplefinAccount, etc.) * Add generic provider_import_adapter * Finish unified import strategy * Update app/models/plaid_account.rb Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: soky srm <[email protected]> * Update app/models/provider/factory.rb Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: soky srm <[email protected]> * Fix account linked by plaid_id instead of external_id * Parse numerics to BigDecimal Parse numerics to BigDecimal before computing amount; guard nils. Avoid String * String and float drift; also normalize date. * Fix incorrect usage of assert_raises. * Fix linter * Fix processor test. * Update current_balance_manager.rb * Test fixes * Fix plaid linked account test * Add support for holding per account_provider * Fix proper account access Also fix account deletion for simpefin too * FIX match tests for consistency * Some more factory updates * Fix account schema for multipe providers Can do: - Account #1 → PlaidAccount + SimplefinAccount (multiple different providers) - Account #2 → PlaidAccount only - Account #3 → SimplefinAccount only Cannot do: - Account #1 → PlaidAccount + PlaidAccount (duplicate provider type) - PlaidAccount we-promise#123 → Account #1 + Account #2 (provider linked to multiple accounts) * Fix account setup - An account CAN have multiple providers (the schema shows account_providers with unique index on [account_id, provider_type]) - Each provider should maintain its own separate entries - We should NOT update one provider's entry when another provider syncs * Fix linter and guard migration * FIX linter issues. * Fixes - Remove duplicated index - Pass account_provider_id - Guard holdings call to avoid NoMethodError * Update schema and provider import fix * Plaid doesn't allow holdings deletion * Use ClimateControl for proper env setup * No need for this in .git --------- Signed-off-by: soky srm <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Juan José Mata <[email protected]> commit 72e7d77 Author: Juan José Mata <[email protected]> Date: Mon Oct 27 21:52:37 2025 +0100 Add onboarding state selector for self-hosted signup (we-promise#251) * Add onboarding modes to self-hosted signup * Style form consistently * Configure ONBOARDING_STATE via ENV commit dcb6748 Author: ampersandru <[email protected]> Date: Mon Oct 27 04:18:45 2025 -0700 Added a clickable drop down arrow that reveals list of instructions for Brand Fetch Client ID (we-promise#246) * Added a clickable drop down arrow that reveals list of instructions for Brand Fetch Client ID Signed-off-by: ampersandru <[email protected]> * Updated html code based on recommendations Signed-off-by: ampersandru <[email protected]> * Update _brand_fetch_settings.html.erb Signed-off-by: ampersandru <[email protected]> * Small edit for consistency with Twelve Data settings flow * HTML linting * Missed an extra closing tag. --------- Signed-off-by: ampersandru <[email protected]> Signed-off-by: Juan José Mata <[email protected]> Co-authored-by: Juan José Mata <[email protected]> commit cca14c9 Author: ampersandru <[email protected]> Date: Mon Oct 27 03:45:01 2025 -0700 Added a clickable drop down arrow that reveals list of instructions for Twelve Data Secret Key (we-promise#247) * Added a clickable drop down arrow that reveals list of instructions for Twelve Data Secret Key Signed-off-by: ampersandru <[email protected]> * Fixed html spacing Signed-off-by: ampersandru <[email protected]> * Make display even more compact * Remove <u> and use CSS classes instead --------- Signed-off-by: ampersandru <[email protected]> Co-authored-by: Juan José Mata <[email protected]> commit 0fc70e9 Author: Juan José Mata <[email protected]> Date: Sun Oct 26 23:16:25 2025 +0100 Add runServices for db and redis in devcontainer Signed-off-by: Juan José Mata <[email protected]> commit d3d91f4 Author: Juan José Mata <[email protected]> Date: Sun Oct 26 20:53:18 2025 +0100 Add PikaPods One-click installs Signed-off-by: Juan José Mata <[email protected]> commit 53eb90f Author: ampersandru <[email protected]> Date: Sun Oct 26 09:58:18 2025 -0700 Added instructions on where and how to obtain API key for Twelve Data (we-promise#235) * Added instructions on where and how to obtain API key for Twelve Data Signed-off-by: ampersandru <[email protected]> * added rel="noopener noreferrer" to links Signed-off-by: ampersandru <[email protected]> --------- Signed-off-by: ampersandru <[email protected]> commit a35a4ac Author: Juan José Mata <[email protected]> Date: Sun Oct 26 17:51:31 2025 +0100 Update version to 0.6.5-alpha.3 Prepare for alpha.3 Signed-off-by: Juan José Mata <[email protected]> commit f42e6e3 Author: Albert Solà <[email protected]> Date: Sun Oct 26 16:50:31 2025 +0000 Added translations for ca - Catalan (we-promise#238) * Add CA locales for models * Add CA locales for views * Use translations in activity feed * Additional CA locales * Fix typo --------- Co-authored-by: Juan José Mata <[email protected]> commit db19c95 Author: ampersandru <[email protected]> Date: Sun Oct 26 09:47:29 2025 -0700 Add instructions on how to obtain Brand Logo Client ID API (we-promise#234) * Add instructions on how to obtain Brand Logo Client ID API Signed-off-by: ampersandru <[email protected]> * updated html based on recommendations Signed-off-by: ampersandru <[email protected]> * added rel="noopener noreferrer" to links Signed-off-by: ampersandru <[email protected]> --------- Signed-off-by: ampersandru <[email protected]> commit 0b393a0 Author: OrangeDrangon <[email protected]> Date: Sun Oct 26 11:58:26 2025 -0400 add custom s3 support storage config option (we-promise#239) Options are documented here including an example on how to set a custom endpoint: https://guides.rubyonrails.org/active_storage_overview.html#s3-service-amazon-s3-and-s3-compatible-apis commit fea228d Author: luckyPipewrench <[email protected]> Date: Sun Oct 26 10:50:45 2025 -0400 Simplefin sync improvements (we-promise#240) * Fix syncing issues with new connections and accounts.. - Keep SimpleFin institution metadata strictly per account (`simplefin_accounts.org_data`). - Relax `simplefin_items` institution constraints to allow creating items before org data exists. - Remove code that copied the first account’s `org` onto `simplefin_items`. * Improve Simplefin Sync • SimpleFin: family “Sync” includes SimpleFin items; importer does unbounded discovery (with pending=1 fallback) before windowed fetch, for both regular and first syncs. • Stop populating item‑level institution fields; keep institution metadata per account. • Relax NOT NULL on item institution fields. • Post‑sync dashboard broadcasts are now guarded (UI cannot fail the job). • Show a friendly “daily refresh limit” banner on the SimpleFin card when the latest sync is rate‑limited. • Add bin/rails sure:simplefin:debug[ITEM_ID] to print latest sync, snapshot account count, simplefin_accounts count, and unlinked list. * Fixed double‑quoted strings, spacing around array brackets and commas * chore: ignore local .junie files * - Broadcast error logs now include full backtraces - SimpleFin discovery logic deduplicated fixed - app/models/simplefin_item/importer.rb --Added a concise docstring for perform_account_discovery describing purpose, steps, and side‑effects. --Added a docstring for fetch_accounts_data describing params and return value. commit f9f6274 Author: Juan José Mata <[email protected]> Date: Sat Oct 25 22:57:49 2025 +0200 Make logo work in dark mode Signed-off-by: Juan José Mata <[email protected]> commit 1ee20ab Author: Copilot <[email protected]> Date: Sat Oct 25 22:23:28 2025 +0200 Eliminate code duplication in OIDC identity creation (we-promise#230) * Eliminate duplication by using create_from_omniauth method - Updated OidcIdentity.create_from_omniauth to set last_authenticated_at - Refactored OidcAccountsController to use create_from_omniauth instead of direct create! calls - Updated test to verify last_authenticated_at is set by create_from_omniauth Co-authored-by: jjmata <[email protected]> * Extract auth hash building into private helper method - Added build_auth_hash helper method to eliminate OpenStruct creation duplication - Both create_link and create_user actions now use the same helper Co-authored-by: jjmata <[email protected]> * Linter fix * Fix button style on OIDC link step * Fix dark mode styles --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: jjmata <[email protected]> Co-authored-by: Juan José Mata <[email protected]> commit b24b102 Author: luckyPipewrench <[email protected]> Date: Fri Oct 24 14:41:33 2025 -0400 Fix rounding issue (we-promise#226) Remove rounding from transactions. commit 03cac95 Author: soky srm <[email protected]> Date: Fri Oct 24 19:39:42 2025 +0200 Category improvements (we-promise#232) * Category improvements - Updated default categories to a more inclusive set - Updated default icon set for categories - Updated default categories colors to better separate then. * FIX tests * Better color pallettes for a few commit 962ddd1 Author: Juan José Mata <[email protected]> Date: Fri Oct 24 19:25:36 2025 +0200 Refresh README with new logo and LLM conversation in screenshot Signed-off-by: Juan José Mata <[email protected]> commit b001d1c Author: Marc <[email protected]> Date: Fri Oct 24 19:02:54 2025 +0200 I have created a one click deploy button for railway users 🧙♂️ (we-promise#228) * Add Railway deployment button to README Signed-off-by: Marc <[email protected]> commit 4ba8f32 Author: Juan José Mata <[email protected]> Date: Fri Oct 24 18:11:31 2025 +0200 Fix production OIDC regression Signed-off-by: Juan José Mata <[email protected]> commit 768e85c Author: Juan José Mata <[email protected]> Date: Fri Oct 24 16:07:45 2025 +0200 Add OpenID Connect login support (we-promise#77) * Add OpenID Connect login support * Add docs for OIDC config with Google Auth * Use Google styles for log in - Add support for linking existing account - Force users to sign-in with passoword first, when linking existing accounts - Add support to create new user when using OIDC - Add identities to user to prevent account take-ver - Make tests mocking instead of being integration tests - Manage session handling correctly - use OmniAuth.config.mock_auth instead of passing auth data via request env * Conditionally render Oauth button - Set a config item `configuration.x.auth.oidc_enabled` - Hide button if disabled --------- Signed-off-by: Juan José Mata <[email protected]> Signed-off-by: soky srm <[email protected]> Co-authored-by: sokie <[email protected]> commit d51ba51 Author: Copilot <[email protected]> Date: Fri Oct 24 13:33:06 2025 +0200 Fix Twelve Data API parsing errors causing "Current Market Price Unknown" (we-promise#224) * Add tests and fix for Twelve Data API parsing errors * Fix search_securities to handle nil data key --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: jjmata <[email protected]> Co-authored-by: Juan José Mata <[email protected]> commit a8f318c Author: Copilot <[email protected]> Date: Fri Oct 24 12:04:19 2025 +0200 Fix "Messages is invalid" error for Ollama/custom LLM providers and add comprehensive AI documentation (we-promise#225) * Add comprehensive AI/LLM configuration documentation * Fix Chat.start! to use default model when model is nil or empty * Ensure all controllers use Chat.default_model for consistency * Move AI doc inside `hosting/` * Probably too much error handling --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: jjmata <[email protected]> Co-authored-by: Juan José Mata <[email protected]> commit 4f44630 Author: Juan José Mata <[email protected]> Date: Fri Oct 24 00:16:29 2025 +0200 Bump version to 0.6.5-alpha.1 Signed-off-by: Juan José Mata <[email protected]> commit bb364fa Author: soky srm <[email protected]> Date: Fri Oct 24 00:08:59 2025 +0200 LLM cost estimation (we-promise#223) * Password reset back button also after confirmation Signed-off-by: Juan José Mata <[email protected]> * Implement a filter for category (we-promise#215) - Also implement an is empty/is null condition. * Implement an LLM cost estimation page Track costs across all the cost categories: auto categorization, auto merchant detection and chat. Show warning with estimated cost when running a rule that contains AI. * Update pricing * Add google pricing and fix inferred model everywhere. * Update app/models/llm_usage.rb Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: soky srm <[email protected]> * FIX address review * Linter * Address review - Lowered log level - extracted the duplicated record_usage method into a shared concern * Update app/controllers/settings/llm_usages_controller.rb Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: soky srm <[email protected]> * Moved attr_reader out of private --------- Signed-off-by: Juan José Mata <[email protected]> Signed-off-by: soky srm <[email protected]> Co-authored-by: Juan José Mata <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
alessiocappa
pushed a commit
to alessiocappa/sure
that referenced
this pull request
Nov 16, 2025
* Add CA locales for models * Add CA locales for views * Use translations in activity feed * Additional CA locales * Fix typo --------- Co-authored-by: Juan José Mata <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Localization