Skip to content

Conversation

@jcochran93
Copy link

This PR adds the following:

More frontmatter fields

  • distance_miles
  • avg_pace_min_per_mile
  • workout_type
  • gear_name
  • splits:
    • distance
    • elapsed_time
    • elevation_difference
    • moving_time
    • split
    • average_speed
    • average_grade_adjusted_speed
    • average_heartrate
    • pace_zone

Nested folders for import

If the Folder setting ends with {{start_date}}, then the folder will be nested based on how the Folder date format setting is specified.

For example, havingStrava/{{start_date}} and yyyy-MM will result in activities added to a folder based on the month they were completed. Ex: Strava/2025/02/13627062814 Lunch Run.md

This makes it easier to find specific activities within Obsidian and speeds up the loading time when opening the main Strava folder.

Configurable last activity synced timestamp

The UTC timestamp of the last synced timestamp is shown and can be changed withing Settings.

This is helpful if you need to redownload some activities, if you wish to add different frontmatter fields recent activities, or if you wish to sync specific batches of activities from the API and not the CSV export.

@watsonbox
Copy link
Owner

Hey @jcochran93, thanks a lot for all this effort! However, I'm afraid there's much too much in the one PR to consider for merging. There are README changes (including making you the maintainer and referring to your fork), author and name changes in the manifest, as well as several version bumps (which should be independent of any specific functional PR). More generally, any discussion around any one aspect of this set of changes would hold up integrating any others.

That said, I certainly don't want you to spend time splitting up changes only for them to end up unmerged, so I'll try to find some time ASAP to go through your suggestions and come back to you 🙂.

@jcochran93
Copy link
Author

Hey @watsonbox, thanks for looking over my work! I realized this morning that I left the references to myself in those documents. That's my bad! Please let me know how I can help with the PR if you want to merge some of these changes.

@watsonbox
Copy link
Owner

I realized this morning that I left the references to myself in those documents. That's my bad!

No worries! I likely won't get back to this before next weekend now, but I did have a question on the following:

If the Folder setting ends with {{start_date}}, then the folder will be nested based on how the Folder date format setting is specified.

For example, having Strava/{{start_date}} and yyyy-MM will result in activities added to a folder based on the month they were completed. Ex: Strava/2025/02/13627062814 Lunch Run.md

This makes it easier to find specific activities within Obsidian and speeds up the loading time when opening the main Strava folder.

I can't see what this extra code adds that wouldn't already be achieved by setting the folder date format to yyyy/MM 🤔. Also, would the changes on this PR make it impossible to continue to use the current format? (i.e. a breaking change)

@jcochran93
Copy link
Author

You are correct about simply using the format yyyy/MM! I should have tested it more thoroughly or looked at ILLEGAL_CHAR_REGEX_FOLDER a little closer.

Yes, this change is a breaking change, but it is also redundant so I will remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants