feat: Add loading labels to hCMS #3116
Draft
+459
−147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## What's the purpose of this pull request? Add the fallback label to hCMS so it can be editable. We need it there so it can be translated through the CMS.⚠️ Breaking change: there is no more a hardcoded fallback label, the message necessarily has to come through CMS. This PR will be merged in the `feat/multilanguage` feature branch, which will be available only in the next faststore major version. ## How it works? It was hardcoded, so adding it to the hCMS schema allows it to be editable. ## How to test it? In a Search page, observe the breadcrumb, it should have the value configured through the hCMS. <img width="1028" height="501" alt="Screenshot 2025-11-04 at 10 27 49" src="https://github.com/user-attachments/assets/30d38c18-202c-4fa7-aeb5-5e8416019b4f" /> If the field is not being displayed in the hCMS, remember to cms sync and publish the page. <img width="1497" height="757" alt="Screenshot 2025-11-04 at 10 37 38" src="https://github.com/user-attachments/assets/d253597b-5953-4ebd-9931-2c3afb324994" /> ### Starters Deploy Preview - https://storeframework-cm652ufll028lmgv665a6xv0g-77wksgb4k.b.vtex.app/s?q=pizza ([PR](vtex-sites/faststoreqa.store#886)) ## References - [Jira task](https://vtex-dev.atlassian.net/browse/SFS-2921)
## What's the purpose of this pull request? Add the Sort by selector labels to hCMS so it can be editable. We need it there so it can be translated through the CMS.⚠️ Breaking change: there is no more sort options hardcoded, the values necessarily have to come through CMS. This PR will be merged in the `feat/multilanguage` feature branch, which will be available only in the next faststore major version. ## How it works? It was hardcoded, so adding it to the hCMS schema allows it to be editable. ## How to test it? In a Search page or PLP, observe the Sort by selector, it should have the values configured through the hCMS. | PLP | Search | | ---- | ---- | | <img width="1031" height="922" alt="Screenshot 2025-11-05 at 09 57 37" src="https://github.com/user-attachments/assets/40379935-78f7-402c-9020-662bdc824bbe" /> | <img width="1024" height="915" alt="Screenshot 2025-11-05 at 09 57 55" src="https://github.com/user-attachments/assets/bde4a107-b6dd-414e-a592-bb29ffae1788" /> | | <img width="1502" height="505" alt="Screenshot 2025-11-05 at 14 25 01" src="https://github.com/user-attachments/assets/f4c6fcbf-b4a1-4f8d-98ec-b49f7dfde6d5" /> | <img width="1502" height="438" alt="Screenshot 2025-11-05 at 14 25 18" src="https://github.com/user-attachments/assets/8f0f10aa-b38c-479e-9a09-3d58f9b582d8" /> | If the field is not being displayed in the hCMS, remember to cms sync and publish the page. ### Starters Deploy Preview - https://brandless-cma5xay4001f6dn4xjwato8b4-4tvja66oo.b.vtex.app/ ([PR](vtex-sites/brandless.store#113)) ## References - [Jira task](https://vtex-dev.atlassian.net/browse/SFS-2915)
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
hellofanny
force-pushed
the
feat/product-comparison-sort-options-cms
branch
from
cb2bcca to
d86aa21
Compare
Base automatically changed from
feat/product-comparison-sort-options-cms
to
feat/multilanguage
November 17, 2025 15:54
lemagnetic
force-pushed
the
feat/multilanguage
branch
from
ff87468 to
8d847df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Add the loading labels to hCMS so they can be editable. We need them there so they can be translated through the CMS.
This PR will be merged in the
feat/multilanguagefeature branch, which will be available only in the next faststore major version.How it works?
It was hardcoded, so adding it to the hCMS schema allows it to be editable.
There were a lot of places with a loading label hardcoded, I've fixed those in this PR:
How to test it?
Sync hCMS, publish all pages/content-types related: Global sections, pages with "Search" section and the PDP (ProductDetails section). Then, navigate through the pages and watch for the use cases.
Starters Deploy Preview
References