feat: Add Sort by selector labels to hCMS #3100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
lariciamota
force-pushed
the
chore/sort-options-cms
branch
from
24bbf9f to
b2237bd
Compare
lariciamota
changed the base branch from
feat/multilanguage
to
chore/breadcrumb-title-cms
lariciamota
requested review from
eduardoformiga and
emersonlaurentino
and removed request for
a team
lemagnetic
approved these changes
Nov 5, 2025
Contributor
lemagnetic
left a comment
lemagnetic
left a comment
There was a problem hiding this comment.
Tested on the preview URL, everything’s working fine! “Sort by” labels are coming from hCMS
Base automatically changed from
chore/breadcrumb-title-cms
to
feat/multilanguage
November 5, 2025 19:14
lariciamota
force-pushed
the
chore/sort-options-cms
branch
from
b2237bd to
08b5527
Compare
lemagnetic
pushed a commit
that referenced
this pull request
Nov 20, 2025
## What's the purpose of this pull request? Add the Sort by selector labels to hCMS so it can be editable. We need it there so it can be translated through the CMS.⚠️ Breaking change: there is no more sort options hardcoded, the values necessarily have to come through CMS. This PR will be merged in the `feat/multilanguage` feature branch, which will be available only in the next faststore major version. ## How it works? It was hardcoded, so adding it to the hCMS schema allows it to be editable. ## How to test it? In a Search page or PLP, observe the Sort by selector, it should have the values configured through the hCMS. | PLP | Search | | ---- | ---- | | <img width="1031" height="922" alt="Screenshot 2025-11-05 at 09 57 37" src="https://github.com/user-attachments/assets/40379935-78f7-402c-9020-662bdc824bbe" /> | <img width="1024" height="915" alt="Screenshot 2025-11-05 at 09 57 55" src="https://github.com/user-attachments/assets/bde4a107-b6dd-414e-a592-bb29ffae1788" /> | | <img width="1502" height="505" alt="Screenshot 2025-11-05 at 14 25 01" src="https://github.com/user-attachments/assets/f4c6fcbf-b4a1-4f8d-98ec-b49f7dfde6d5" /> | <img width="1502" height="438" alt="Screenshot 2025-11-05 at 14 25 18" src="https://github.com/user-attachments/assets/8f0f10aa-b38c-479e-9a09-3d58f9b582d8" /> | If the field is not being displayed in the hCMS, remember to cms sync and publish the page. ### Starters Deploy Preview - https://brandless-cma5xay4001f6dn4xjwato8b4-4tvja66oo.b.vtex.app/ ([PR](vtex-sites/brandless.store#113)) ## References - [Jira task](https://vtex-dev.atlassian.net/browse/SFS-2915)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Add the Sort by selector labels to hCMS so it can be editable. We need it there so it can be translated through the CMS.
This PR will be merged in the
feat/multilanguagefeature branch, which will be available only in the next faststore major version.How it works?
It was hardcoded, so adding it to the hCMS schema allows it to be editable.
How to test it?
In a Search page or PLP, observe the Sort by selector, it should have the values configured through the hCMS.
If the field is not being displayed in the hCMS, remember to cms sync and publish the page.
Starters Deploy Preview
References