Skip to content

[rollout] fix: Fix local rank binding issue when setting RAY_EXPERIMENTAL_NOSET_ASCEND_RT_VISIBLE_DEVICES #2967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 7, 2025
Merged

[rollout] fix: Fix local rank binding issue when setting RAY_EXPERIMENTAL_NOSET_ASCEND_RT_VISIBLE_DEVICES #2967

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f2d37b5
Fixed local rank binding issue when setting RAY_EXPERIMENTAL_NOSET_AS…
Aug 7, 2025
739a822
Reuse existing logic
Aug 7, 2025
a1c21d7
code style
Aug 7, 2025
2b10d2d
style: fix import order with ruff
Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions verl/workers/rollout/vllm_rollout/vllm_rollout_spmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@

from verl import DataProto
from verl.utils.profiler import GPUMemoryLogger
from verl.utils.ray_utils import ray_noset_visible_devices
from verl.utils.torch_functional import get_response_mask, pad_2d_list_to_length
from verl.workers.rollout.base import BaseRollout

Expand Down Expand Up @@ -459,8 +460,7 @@ def get_zeromq_address(self):
def init_worker(self, all_kwargs: list[dict[str, Any]]):
"""Initialize worker engine."""
all_kwargs[0]["rank"] = int(os.environ["RANK"])
all_kwargs[0]["local_rank"] = 0

all_kwargs[0]["local_rank"] = 0 if not ray_noset_visible_devices() else int(os.environ.get("RAY_LOCAL_RANK", 0))
self.vllm_config = all_kwargs[0]["vllm_config"]
self.inference_engine = WorkerWrapperBase(vllm_config=self.vllm_config)
self.inference_engine.init_worker(all_kwargs)
Expand Down