[rollout] fix: Fix local rank binding issue when setting RAY_EXPERIMENTAL_NOSET_ASCEND_RT_VISIBLE_DEVICES #2967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CEND_RT_VISIBLE_DEVICES
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a local rank binding issue for Ascend devices when the RAY_EXPERIMENTAL_NOSET_ASCEND_RT_VISIBLE_DEVICES environment variable is set. The logic correctly assigns the local rank based on RAY_LOCAL_RANK when this setting is active, and otherwise defaults to 0. While the fix itself is correct, I have raised a high-severity maintainability concern about the implementation. The new code introduces logic that is conceptually duplicated elsewhere in the codebase, creating a risk of future inconsistencies and bugs.
wuxibin89
approved these changes
Aug 7, 2025
girishbarca
pushed a commit
to cgftinc/verl
that referenced
this pull request
Aug 10, 2025
…NTAL_NOSET_ASCEND_RT_VISIBLE_DEVICES (volcengine#2967) ### What does this PR do? Fix local rank binding issue when setting RAY_EXPERIMENTAL_NOSET_ASCEND_RT_VISIBLE_DEVICES ### Checklist Before Starting [done] Search for similar PR(s). ### Design & Code Changes change verl/verl/workers/rollout/vllm_rollout/vllm_rollout_spmd.py ### Checklist Before Submitting [ done ] Read the [Contribute Guide](https://github.com/volcengine/verl?tab=readme-ov-file#contribution-guide). [ done ] Apply [pre-commit checks](https://github.com/volcengine/verl?tab=readme-ov-file#code-linting-and-formatting). --------- Co-authored-by: liaochangyue <[email protected]>
yellowbee686
pushed a commit
to yellowbee686/verl
that referenced
this pull request
Aug 11, 2025
…NTAL_NOSET_ASCEND_RT_VISIBLE_DEVICES (volcengine#2967) ### What does this PR do? Fix local rank binding issue when setting RAY_EXPERIMENTAL_NOSET_ASCEND_RT_VISIBLE_DEVICES ### Checklist Before Starting [done] Search for similar PR(s). ### Design & Code Changes change verl/verl/workers/rollout/vllm_rollout/vllm_rollout_spmd.py ### Checklist Before Submitting [ done ] Read the [Contribute Guide](https://github.com/volcengine/verl?tab=readme-ov-file#contribution-guide). [ done ] Apply [pre-commit checks](https://github.com/volcengine/verl?tab=readme-ov-file#code-linting-and-formatting). --------- Co-authored-by: liaochangyue <[email protected]>
whatadayG
pushed a commit
to whatadayG/verl
that referenced
this pull request
Sep 5, 2025
…NTAL_NOSET_ASCEND_RT_VISIBLE_DEVICES (volcengine#2967) ### What does this PR do? Fix local rank binding issue when setting RAY_EXPERIMENTAL_NOSET_ASCEND_RT_VISIBLE_DEVICES ### Checklist Before Starting [done] Search for similar PR(s). ### Design & Code Changes change verl/verl/workers/rollout/vllm_rollout/vllm_rollout_spmd.py ### Checklist Before Submitting [ done ] Read the [Contribute Guide](https://github.com/volcengine/verl?tab=readme-ov-file#contribution-guide). [ done ] Apply [pre-commit checks](https://github.com/volcengine/verl?tab=readme-ov-file#code-linting-and-formatting). --------- Co-authored-by: liaochangyue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix local rank binding issue when setting RAY_EXPERIMENTAL_NOSET_ASCEND_RT_VISIBLE_DEVICES
Checklist Before Starting
[done] Search for similar PR(s).
Design & Code Changes
change verl/verl/workers/rollout/vllm_rollout/vllm_rollout_spmd.py
Checklist Before Submitting
[ done ] Read the Contribute Guide.
[ done ] Apply pre-commit checks.