feat(typescript): supports new params of getQuickInfoAtPosition
#285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
serkodev
commented
Aug 8, 2025
Contributor
Author
serkodev
left a comment
serkodev
left a comment
There was a problem hiding this comment.
Since verbosityLevel is an internal parameter, would it be simpler to just pass through ...args instead of extending the function type?
serkodev
changed the title
maximumLength param of getQuickInfoAtPositiongetQuickInfoAtPosition
johnsoncodehk
changed the title
getQuickInfoAtPositiongetQuickInfoAtPosition
Member
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
maximumLength,verbosityLevelparam support ingetQuickInfoAtPositionFixed vuejs/language-tools#5577
Reference:
microsoft/TypeScript#59940
microsoft/TypeScript#61662
microsoft/vscode#248181
https://devblogs.microsoft.com/typescript/announcing-typescript-5-9/