Skip to content

[Bugfix] Correct adapter usage for cohere and jamba #8292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 9, 2024
Merged

[Bugfix] Correct adapter usage for cohere and jamba #8292

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d11a18
Create initial commit
vladislavkruglikov Sep 9, 2024
2830c7a
Correct adapter usage for jamba model
vladislavkruglikov Sep 9, 2024
c5c9113
Make pretty
vladislavkruglikov Sep 9, 2024
dfd8cfd
Remove duplicate code
vladislavkruglikov Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion vllm/model_executor/models/commandr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@
from vllm.model_executor.utils import set_weight_attrs
from vllm.sequence import IntermediateTensors

from .interfaces import SupportsLoRA


@torch.compile
def layer_norm_func(hidden_states, weight, variance_epsilon):
Expand Down Expand Up @@ -292,7 +294,8 @@ def forward(
return hidden_states


class CohereForCausalLM(nn.Module):
class CohereForCausalLM(nn.Module, SupportsLoRA):
supports_lora = True

packed_modules_mapping = {
"qkv_proj": [
Expand Down
6 changes: 5 additions & 1 deletion vllm/model_executor/models/jamba.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@
from vllm.worker.model_runner import (_BATCH_SIZES_TO_CAPTURE,
_get_graph_batch_size)

from .interfaces import SupportsLoRA

KVCache = Tuple[torch.Tensor, torch.Tensor]


Expand Down Expand Up @@ -539,7 +541,9 @@ def forward(
return hidden_states


class JambaForCausalLM(nn.Module, HasInnerState):
class JambaForCausalLM(nn.Module, HasInnerState, SupportsLoRA):
supports_lora = True

packed_modules_mapping = {
"qkv_proj": [
"q_proj",
Expand Down