Skip to content

Conversation

@vladislavkruglikov
Copy link
Contributor

@vladislavkruglikov vladislavkruglikov commented Sep 9, 2024

Pull request #5018 that broke usage of many models with adapters did not add adapter support for cohere models. In this pull request we inherit cohere language model from common adapter interface as well as author of pull request #5018 did for other models

@github-actions
Copy link

github-actions bot commented Sep 9, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@vladislavkruglikov
Copy link
Contributor Author

@DarkLight1337 some tests are marked as failed. Is there any way to restart failed tests? Also my pull request is ready what do I do next?

@DarkLight1337
Copy link
Member

DarkLight1337 commented Sep 9, 2024

Sorry that my PR broke your code! I can rerun the tests when necessary.

While we're here, can you also update the Jamba model with the new interface? I just did another quick search and found that this model also lacks SupportsLoRA. #5018 probably got merged during the development of this model.

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) September 9, 2024 12:50
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 9, 2024
@DarkLight1337 DarkLight1337 changed the title Correct adapter usage for cohere Correct adapter usage for cohere and jamba Sep 9, 2024
@DarkLight1337 DarkLight1337 changed the title Correct adapter usage for cohere and jamba [Bugfix] Correct adapter usage for cohere and jamba Sep 9, 2024
@DarkLight1337 DarkLight1337 removed the ready ONLY add when PR is ready to merge/full CI is needed label Sep 9, 2024
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) September 9, 2024 13:11
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 9, 2024
@vladislavkruglikov
Copy link
Contributor Author

@DarkLight1337 could you please run failed tests?

@DarkLight1337
Copy link
Member

This is a persistent failure caused by another PR. I'll ask someone to force merge this.

@vladislavkruglikov
Copy link
Contributor Author

@DarkLight1337 all tests have run. Could you please ask someone to force merge if failed tests are causes by another pull requests?

@simon-mo simon-mo disabled auto-merge September 9, 2024 18:20
@simon-mo simon-mo merged commit f9b4a2d into vllm-project:main Sep 9, 2024
@vladislavkruglikov vladislavkruglikov deleted the correct-adapter-usage-for-cohere branch September 9, 2024 19:13
dtrifiro pushed a commit to opendatahub-io/vllm that referenced this pull request Sep 12, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
garg-amit pushed a commit to garg-amit/vllm that referenced this pull request Oct 28, 2024
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants