-
-
Notifications
You must be signed in to change notification settings - Fork 11.7k
[Bugfix] Correct adapter usage for cohere and jamba #8292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Correct adapter usage for cohere and jamba #8292
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
|
@DarkLight1337 some tests are marked as failed. Is there any way to restart failed tests? Also my pull request is ready what do I do next? |
|
Sorry that my PR broke your code! I can rerun the tests when necessary. While we're here, can you also update the Jamba model with the new interface? I just did another quick search and found that this model also lacks |
DarkLight1337
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
|
@DarkLight1337 could you please run failed tests? |
|
This is a persistent failure caused by another PR. I'll ask someone to force merge this. |
|
@DarkLight1337 all tests have run. Could you please ask someone to force merge if failed tests are causes by another pull requests? |
Signed-off-by: Alvant <[email protected]>
Signed-off-by: Amit Garg <[email protected]>
Signed-off-by: LeiWang1999 <[email protected]>
Pull request #5018 that broke usage of many models with adapters did not add adapter support for cohere models. In this pull request we inherit cohere language model from common adapter interface as well as author of pull request #5018 did for other models