Skip to content

[hardware][rocm] allow rocm to override default env var #7926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youkaichao merged 4 commits into from
Aug 28, 2024
Merged

[hardware][rocm] allow rocm to override default env var #7926

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d47bfb6
allow rocm to override env var
youkaichao Aug 27, 2024
705d796
fix lint
youkaichao Aug 27, 2024
540ebae
fix
youkaichao Aug 28, 2024
5354627
strange lint
youkaichao Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions vllm/platforms/rocm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,21 @@
import os
from functools import lru_cache
from typing import Tuple

import torch

from vllm.logger import init_logger

from .interface import Platform, PlatformEnum

logger = init_logger(__name__)

if os.environ.get("VLLM_WORKER_MULTIPROC_METHOD", None) == "fork":
logger.warning("`fork` method is not supported by ROCm. "
"VLLM_WORKER_MULTIPROC_METHOD is overridden to"
" `spawn` instead.")
os.environ["VLLM_WORKER_MULTIPROC_METHOD"] = "spawn"


class RocmPlatform(Platform):
_enum = PlatformEnum.ROCM
Expand Down