Skip to content

Conversation

@youkaichao
Copy link
Member

fixes #7791

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@hongxiayang
Copy link
Collaborator

Thanks for the fix. @youkaichao

@WoosukKwon WoosukKwon added the rocm Related to AMD ROCm label Aug 27, 2024
Copy link

@clintg6 clintg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work. The if statement will never execute here because it is initially None not fork. All that's needed is

os.environ["VLLM_WORKER_MULTIPROC_METHOD"] = "spawn"
logger.warning("VLLM_WORKER_MULTIPROC_METHOD is overridden to `spawn`.")

@youkaichao
Copy link
Member Author

how about now?

Copy link

@clintg6 clintg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully runs and handles inference requests. Fixes issue in #7791.

@youkaichao youkaichao merged commit bc6e42a into vllm-project:main Aug 28, 2024
@youkaichao youkaichao deleted the rocm_override branch August 28, 2024 02:50
kushanam pushed a commit to kushanam/vllm that referenced this pull request Aug 28, 2024
kushanam pushed a commit to kushanam/vllm that referenced this pull request Aug 28, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rocm Related to AMD ROCm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Critical distributed executor bug

4 participants