-
-
Notifications
You must be signed in to change notification settings - Fork 11.9k
[hardware][rocm] allow rocm to override default env var #7926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge). To run full CI, you can do one of these:
🚀 |
|
Thanks for the fix. @youkaichao |
clintg6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not work. The if statement will never execute here because it is initially None not fork. All that's needed is
os.environ["VLLM_WORKER_MULTIPROC_METHOD"] = "spawn"
logger.warning("VLLM_WORKER_MULTIPROC_METHOD is overridden to `spawn`.")|
how about now? |
clintg6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested successfully runs and handles inference requests. Fixes issue in #7791.
…#7926) Signed-off-by: Alvant <[email protected]>
…#7926) Signed-off-by: LeiWang1999 <[email protected]>
fixes #7791