[BugFix] Fix mixed penalties batch with async scheduling #27910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a bug in async scheduling where a batch containing a mix of requests with and without penalties could fail. The fix involves replacing placeholder -1 token IDs with a valid token ID to prevent errors in downstream operations. The approach is sound. I've suggested a minor improvement to make the fix more robust by using vocab_size as the replacement value, which is already used as a padding/ignore value, instead of 0.
1 task
Signed-off-by: Nick Hill <[email protected]>
njhill
force-pushed
the
fix-async-penalties
branch
from
36e9424 to
1aecaef
Compare
This was referenced Nov 1, 2025
mgoin
approved these changes
Nov 1, 2025
zhaozuy
pushed a commit
to zhaozuy/vllm
that referenced
this pull request
Nov 4, 2025
…t#27910) Signed-off-by: Nick Hill <[email protected]>
juliendenize
pushed a commit
to juliendenize/vllm
that referenced
this pull request
Nov 6, 2025
…t#27910) Signed-off-by: Nick Hill <[email protected]>
ZhengHongming888
pushed a commit
to ZhengHongming888/vllm
that referenced
this pull request
Nov 8, 2025
…t#27910) Signed-off-by: Nick Hill <[email protected]>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
…t#27910) Signed-off-by: Nick Hill <[email protected]>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
…t#27910) Signed-off-by: Nick Hill <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#26467 fixed compatibility of penalties sampling parameters with async scheduling but has a flaw that it breaks in cases where there is a mix of requests with and without penalties in the batch, specifically if a request with a penalties param starts while a batch without penalties is already running.
This is a fix for that case.