-
Notifications
You must be signed in to change notification settings - Fork 98
Update the docs for --async-scheduling compatibility
#131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @zhandaz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the documentation for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Signed-off-by: zhanda <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the documentation for the --async-scheduling flag in GPT-OSS.md and Qwen3-VL.md to reflect recent compatibility improvements in vLLM. The changes are generally good and informative. I've provided a few suggestions to improve clarity, consistency, and accuracy. The most important feedback is regarding a potentially misleading statement in Qwen/Qwen3-VL.md where a warning about incompatibility with speculative decoding was removed, while it seems it should be preserved based on the PR description. Other comments focus on improving the wording for conciseness and consistency across the documents.
Signed-off-by: zhanda <[email protected]>
Overview
Updates the documentation for
--async-schedulingflag in Qwen3-VL and GPT-OSS guides to reflect compatibility improvements in new vLLM releases.--async-schedulingto indicate that vLLM >= 0.11.1 now provides compatibility with structured outputContext
The
--async-schedulingflag was previously incompatible with structured outputs. This limitation was resolved in vLLM 0.11.1 (merged in #26866), along with other improvements: penalty fix 1 #26467 (included in 0.11.1), penalty fix 2 #27910 (included in 0.11.1), spec decode #29223 (merged but not included in 0.11.2).