Skip to content

Remove deprecated fields from CompilationConfig #27593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Nov 12, 2025
Merged

Remove deprecated fields from CompilationConfig #27593

merged 20 commits into from
Nov 12, 2025

Conversation

@hmellor
Copy link
Member

@hmellor hmellor commented Oct 27, 2025

@mergify
Copy link

mergify bot commented Oct 27, 2025

Documentation preview: https://vllm--27593.org.readthedocs.build/en/27593/

@mergify mergify bot added documentation Improvements or additions to documentation llama Related to Llama models v1 labels Oct 27, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 27, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the deprecated use_cudagraph and full_cuda_graph fields from the CompilationConfig and updates the config tests accordingly. The removal of these flags simplifies the configuration and aligns with the deprecation schedule. The test updates ensure the config tests are passing.

@hmellor
pre-commit
a51d54d 
Signed-off-by: Harry Mellor <[email protected]>
@ZJY0516
Copy link
Contributor

ZJY0516 commented Oct 28, 2025 •
edited
Loading

CC @fhl2000 @ProExpertProg

fhl2000
fhl2000 approved these changes Oct 28, 2025
View reviewed changes
Copy link
Contributor

@fhl2000 fhl2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing the deprecations!

simon-mo
simon-mo approved these changes Oct 28, 2025
View reviewed changes
Copy link
Collaborator

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp

@hmellor hmellor enabled auto-merge (squash) October 28, 2025 20:43
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 28, 2025
ProExpertProg
ProExpertProg approved these changes Oct 28, 2025
View reviewed changes
@hmellor
Fix multimodal test
ebca72e 
Signed-off-by: Harry Mellor <[email protected]>
@hmellor
Review comment
e412141 
Signed-off-by: Harry Mellor <[email protected]>
@mergify mergify bot added multi-modality Related to multi-modality (#4194) qwen Related to Qwen models labels Oct 29, 2025
@mergify mergify bot added the ci/build label Oct 31, 2025
@hmellor
Copy link
Member Author

hmellor commented Oct 31, 2025

  • test_use_cudagraphs was failing on main because an extra graph was captured when the default changed from PIECEWISE to FULL_AND_PIECEWISE
  • test_splitting_ops_dynamic still fails because the assertions are not correct

fhl2000
fhl2000 reviewed Oct 31, 2025
View reviewed changes
ProExpertProg
ProExpertProg approved these changes Oct 31, 2025
View reviewed changes
@fhl2000 fhl2000 mentioned this pull request Nov 5, 2025
Closed
@BoyuanFeng BoyuanFeng mentioned this pull request Nov 5, 2025
Closed
@mergify mergify bot added the nvidia label Nov 11, 2025
@hmellor hmellor merged commit a742134 into vllm-project:main Nov 12, 2025
53 checks passed
@hmellor hmellor deleted the remove-deprecated-compilation-fields branch November 12, 2025 16:10
@github-project-automation github-project-automation bot moved this to Done in NVIDIA Nov 12, 2025
@hmellor hmellor added this to the v0.11.1 milestone Nov 14, 2025
geodavic pushed a commit to geodavic/vllm that referenced this pull request Nov 16, 2025
@hmellor @geodavic
Remove deprecated fields from CompilationConfig (vllm-project#27593)
8db884d 
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: George D. Torres <[email protected]>
khluu pushed a commit that referenced this pull request Nov 16, 2025
@hmellor @khluu
Remove deprecated fields from CompilationConfig (#27593)
5b4dcec 
Signed-off-by: Harry Mellor <[email protected]>
(cherry picked from commit a742134)
bwasti pushed a commit to bwasti/vllm that referenced this pull request Nov 17, 2025
@hmellor @bwasti
Remove deprecated fields from CompilationConfig (vllm-project#27593)
53b6d8f 
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Bram Wasti <[email protected]>
devpatelio pushed a commit to SumanthRH/vllm that referenced this pull request Nov 29, 2025
@hmellor @devpatelio
Remove deprecated fields from CompilationConfig (vllm-project#27593)
4976071 
Signed-off-by: Harry Mellor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ProExpertProg ProExpertProg ProExpertProg approved these changes

@simon-mo simon-mo simon-mo approved these changes

@LucasWilkinson LucasWilkinson Awaiting requested review from LucasWilkinson LucasWilkinson is a code owner

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@youkaichao youkaichao Awaiting requested review from youkaichao youkaichao is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@mgoin mgoin Awaiting requested review from mgoin mgoin is a code owner

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth tlrmchlsmth is a code owner

@houseroad houseroad Awaiting requested review from houseroad houseroad is a code owner

@yewentao256 yewentao256 Awaiting requested review from yewentao256 yewentao256 is a code owner

@DarkLight1337 DarkLight1337 Awaiting requested review from DarkLight1337 DarkLight1337 is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

+2 more reviewers

@fhl2000 fhl2000 fhl2000 approved these changes

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci/build documentation Improvements or additions to documentation llama Related to Llama models multi-modality Related to multi-modality (#4194) nvidia qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

NVIDIA
Status: Done

Milestone

v0.11.1

Development

Successfully merging this pull request may close these issues.

5 participants

@hmellor @ZJY0516 @ProExpertProg @simon-mo @fhl2000