[NIXL] heterogeneous block_size support #26759
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -49,6 +49,8 @@ NUM_DECODE_INSTANCES=${NUM_DECODE_INSTANCES:-1} # Default to 1 | |
| PREFILLER_TP_SIZE=${PREFILLER_TP_SIZE:-1} | ||
| DECODER_TP_SIZE=${DECODER_TP_SIZE:-1} | ||
| GPU_MEMORY_UTILIZATION=${GPU_MEMORY_UTILIZATION:-0.2} | ||
| PREFILL_BLOCK_SIZE=${PREFILL_BLOCK_SIZE:-16} | ||
| DECODE_BLOCK_SIZE=${DECODE_BLOCK_SIZE:-16} | ||
|
Contributor
Author
There was a problem hiding this comment. I switched to 128 but switched back to 16 again.
Contributor
Author
There was a problem hiding this comment. I verified setting block_size=64 works, but somehow using block_size=128 for CUDA gets tensor Nan. |
||
|
|
||
| # Find the git repository root directory | ||
| GIT_ROOT=$(git rev-parse --show-toplevel) | ||
|
|
@@ -136,6 +138,7 @@ run_tests_for_model() { | |
| vllm serve $model_name \ | ||
| --port $PORT \ | ||
| --enforce-eager \ | ||
| --block-size ${PREFILL_BLOCK_SIZE} \ | ||
| --gpu-memory-utilization $GPU_MEMORY_UTILIZATION \ | ||
| --tensor-parallel-size $PREFILLER_TP_SIZE \ | ||
| --kv-transfer-config '$KV_CONFIG'" | ||
|
|
@@ -177,6 +180,7 @@ run_tests_for_model() { | |
| vllm serve $model_name \ | ||
| --port $PORT \ | ||
| --enforce-eager \ | ||
| --block-size ${DECODE_BLOCK_SIZE} \ | ||
| --gpu-memory-utilization $GPU_MEMORY_UTILIZATION \ | ||
| --kv-transfer-config '$KV_CONFIG'" | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we default to 128? Block size can significantly impact our transfer efficiency, just having it as kind of suggested value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cuda block_size is currently default to 16, should I change to a large number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep can we set it to 128 at these lines?