-
-
Notifications
You must be signed in to change notification settings - Fork 11.9k
[NIXL] heterogeneous block_size support #26759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vllm-bot
merged 39 commits into
vllm-project:main
from
xuechendi:dev/nixl_heter_blocksize
Nov 15, 2025
Merged
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
dcc1ade
enable hetero blocksize
xuechendi 37e8c4c
Merge remote-tracking branch 'origin/main' into dev/nixl_heter_blocksize
xuechendi 87b1de8
update and cleanup
xuechendi 414215a
naive post process for HND
xuechendi e6e3d92
Both block_size_ratio < 1 or > 1 works
xuechendi f0d8b3a
enable BlockAllocator for prefill/decode block_size_ratio > 1
xuechendi 669ea19
Tested both prefill/decode block_size ratio > 1 and < 1 accuracy
xuechendi 8719d69
Merge remote-tracking branch 'origin/main' into dev/nixl_heter_blocksize
xuechendi ce27358
Enable a second local xfer handler register
xuechendi 826f7ee
Merge remote-tracking branch 'origin/main' into dev/nixl_heter_blocksize
xuechendi 59a3244
remove FIXME
xuechendi 4caca02
remove duplicate func
xuechendi 90c26f4
Limit nP > nD buffer blocks length and print warning when overlapping
xuechendi d9e1bc9
Merge remote-tracking branch 'origin/main' into dev/nixl_heter_blocksize
xuechendi 0872214
small fix on default buffer setting
xuechendi 8ebde3f
Fix for nP > nD + TP_ratio != 1 scenraio
xuechendi 37be2f4
Merge remote-tracking branch 'origin/main' into dev/nixl_heter_blocksize
xuechendi c9dfb51
clean up and remove nnecessary shift
xuechendi 5eb54e1
remove nP > nD path, will do it in seperate PR
xuechendi 7fa82cb
move block_size_ratio to kv_topo
xuechendi 402fadd
use default(list)
xuechendi 9bf9c7f
remove unnecessary changes to _get_block_descs_ids
xuechendi bcce3a7
Clean up
xuechendi b99156a
Inverse block_size_ratio
xuechendi 4d74dd2
Remove unnecessary check
xuechendi aa86c19
Merge remote-tracking branch 'origin/main' into dev/nixl_heter_blocksize
xuechendi 456a8c6
don't do post_process for heter_block_size for mla
xuechendi d0f9035
make pre-commit happy
xuechendi fd21da1
Update vllm/distributed/kv_transfer/kv_connector/v1/nixl_connector.py
xuechendi 160fb6a
Merge remote-tracking branch 'origin/main' into dev/nixl_heter_blocksize
xuechendi 8b4507a
Fix comments
xuechendi 2f176da
Merge remote-tracking branch 'origin/main' into dev/nixl_heter_blocksize
xuechendi 984637d
update script
xuechendi 23808e5
fix script and comments
xuechendi a6641c2
fix UT
xuechendi 2e33323
Merge remote-tracking branch 'origin/main' into dev/nixl_heter_blocksize
xuechendi ad1ee8c
Merge branch 'main' into dev/nixl_heter_blocksize
xuechendi c758c16
Merge branch 'main' into dev/nixl_heter_blocksize
xuechendi 08f4046
Merge branch 'main' into dev/nixl_heter_blocksize
xuechendi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I switched to 128 but switched back to 16 again.
I tested with 128, and noticed that even on origin/main, accuracy is not correct at this moment.
Will see if I can find out main reason in separate PR.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified setting block_size=64 works, but somehow using block_size=128 for CUDA gets tensor Nan.
@NickLucche , do you want me to set as 64? Actually I refer to use current default for CUDA which is 16/