-
-
Notifications
You must be signed in to change notification settings - Fork 11.7k
[CI Failure] Fix fp8 kv cache on <SM90 #25396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI Failure] Fix fp8 kv cache on <SM90 #25396
Conversation
Signed-off-by: mgoin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to fix an issue where FlashAttention was incorrectly chosen for fp8 kv-cache on devices with compute capability less than 9.0, leading to a NotImplementedError. The change correctly modifies the attention backend selection logic to fall back to the Triton backend in this scenario. My main concern is that a pre-check in is_kv_cache_dtype_supported might still fail because it uses a simplified logic that doesn't account for this new fallback, potentially preventing the fix from being effective. I've left a specific comment detailing this critical issue. This should be addressed to ensure the fix is complete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
Signed-off-by: mgoin <[email protected]>
Signed-off-by: mgoin <[email protected]>
Signed-off-by: mgoin <[email protected]> Signed-off-by: charlifu <[email protected]>
Signed-off-by: mgoin <[email protected]> Signed-off-by: yewentao256 <[email protected]>
Signed-off-by: mgoin <[email protected]> Signed-off-by: gaojc <[email protected]>
Signed-off-by: mgoin <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
Signed-off-by: mgoin <[email protected]>
Signed-off-by: mgoin <[email protected]>
Signed-off-by: mgoin <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
Signed-off-by: mgoin <[email protected]>
Purpose
The "Quantization Test" has been broken for a few days due to FA2 being chosen for fp8 kv cache on SM80 and SM89 after this PR removed V0 fallback #25033
https://buildkite.com/vllm/ci/builds/31806/steps/canvas?jid=0199716c-38f4-4409-affd-a1c35d55bc0e
Test Plan
Test Result
pytest -s -v "tests/quantization/test_fp8.py::test_kv_cache_model_load_and_run[False-neuralmagic/Meta-Llama-3-8B-Instruct-FP8-KV]"works on L40sEssential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.