Skip to content

[V0 Deprecation] Remove LLMEngine #25033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Sep 21, 2025
Merged

[V0 Deprecation] Remove LLMEngine #25033

merged 37 commits into from
Sep 21, 2025

Conversation

@WoosukKwon
Copy link
Collaborator

@WoosukKwon WoosukKwon commented Sep 17, 2025

No description provided.

@WoosukKwon WoosukKwon added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 17, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Sep 17, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively removes the V0 LLMEngine and related code, making the V1 engine the sole implementation. The changes are extensive, including the removal of numerous V0-specific tests and code paths, and simplifying the codebase to rely exclusively on the V1 engine. The modifications are consistent and align with the goal of deprecating V0. I have one suggestion to update a misleading warning message that could confuse users.

@WoosukKwon
merge
65b3990 
Signed-off-by: Woosuk Kwon <[email protected]>
@WoosukKwon
fix
51a326d 
Signed-off-by: Woosuk Kwon <[email protected]>
@WoosukKwon
revert
8c2eb56 
Signed-off-by: Woosuk Kwon <[email protected]>
@WoosukKwon
fix test_chat
7a92f17 
Signed-off-by: Woosuk Kwon <[email protected]>
@WoosukKwon
fix pp test
d80a455 
Signed-off-by: Woosuk Kwon <[email protected]>
@WoosukKwon
fix
9bb81fe 
Signed-off-by: Woosuk Kwon <[email protected]>
@mergify
Copy link

mergify bot commented Sep 19, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @WoosukKwon.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Sep 19, 2025
@mergify mergify bot removed the needs-rebase label Sep 19, 2025
WoosukKwon and others added 5 commits September 19, 2025 23:19
@WoosukKwon
rm
277ef29 
Signed-off-by: Woosuk Kwon <[email protected]>
@WoosukKwon
minor
c05504e 
Signed-off-by: Woosuk Kwon <[email protected]>
@WoosukKwon
merge
5fe855d 
Signed-off-by: Woosuk Kwon <[email protected]>
@WoosukKwon
Remove codeowners
60b94e6 
Signed-off-by: Woosuk Kwon <[email protected]>
@WoosukKwon
fix
35c121f 
Signed-off-by: Woosuk Kwon <[email protected]>
@WoosukKwon
fix
becf74c 
Signed-off-by: Woosuk Kwon <[email protected]>
@WoosukKwon
fix
2104774 
Signed-off-by: Woosuk Kwon <[email protected]>
@WoosukKwon
fix
a17686b 
Signed-off-by: Woosuk Kwon <[email protected]>
@WoosukKwon
rm fp8 kv cache fallback & profiling
f2b7215 
Signed-off-by: Woosuk Kwon <[email protected]>
@mergify mergify bot added the documentation Improvements or additions to documentation label Sep 21, 2025
@WoosukKwon
skip
dddbd5e 
Signed-off-by: Woosuk Kwon <[email protected]>
@WoosukKwon WoosukKwon merged commit 52c2a8d into main Sep 21, 2025
11 of 19 checks passed
@WoosukKwon WoosukKwon deleted the woosuk/remove-llm-engine branch September 21, 2025 00:56
@mgoin mgoin mentioned this pull request Sep 22, 2025
Merged
5 tasks
huydhn added a commit to pytorch/pytorch that referenced this pull request Sep 22, 2025
@huydhn
Clean up v0 tests after vllm-project/vllm#25033
b7125b3
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
@WoosukKwon @FeiDaLI
[V0 Deprecation] Remove LLMEngine (vllm-project#25033)
ca4712c 
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
charlifu pushed a commit to ROCm/vllm that referenced this pull request Sep 25, 2025
@WoosukKwon @charlifu
[V0 Deprecation] Remove LLMEngine (vllm-project#25033)
8e6b65b 
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: charlifu <[email protected]>
@markmc markmc mentioned this pull request Sep 30, 2025
Merged
@maxdebayser maxdebayser mentioned this pull request Oct 1, 2025
Merged
5 tasks
yewentao256 pushed a commit that referenced this pull request Oct 3, 2025
@WoosukKwon @yewentao256
[V0 Deprecation] Remove LLMEngine (#25033)
32d43a5 
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: yewentao256 <[email protected]>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
@WoosukKwon @xuebwang-amd
[V0 Deprecation] Remove LLMEngine (vllm-project#25033)
7a6b52c 
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: xuebwang-amd <[email protected]>
choprahetarth pushed a commit to Tandemn-Labs/vllm that referenced this pull request Oct 11, 2025
@WoosukKwon @choprahetarth
[V0 Deprecation] Remove LLMEngine (vllm-project#25033)
1e60187 
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
lywa1998 pushed a commit to lywa1998/vllm that referenced this pull request Oct 20, 2025
@WoosukKwon @lywa1998
[V0 Deprecation] Remove LLMEngine (vllm-project#25033)
336252b 
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
@WoosukKwon @xuebwang-amd
[V0 Deprecation] Remove LLMEngine (vllm-project#25033)
d0587dd 
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: xuebwang-amd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeejeelee jeejeelee Awaiting requested review from jeejeelee jeejeelee is a code owner

@DarkLight1337 DarkLight1337 Awaiting requested review from DarkLight1337 DarkLight1337 is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@njhill njhill Awaiting requested review from njhill

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@simon-mo simon-mo Awaiting requested review from simon-mo

@aarnphm aarnphm Awaiting requested review from aarnphm aarnphm is a code owner

@chaunceyjiang chaunceyjiang Awaiting requested review from chaunceyjiang chaunceyjiang is a code owner

@22quinn 22quinn Awaiting requested review from 22quinn 22quinn is a code owner

@zhuohan123 zhuohan123 Awaiting requested review from zhuohan123

@youkaichao youkaichao Awaiting requested review from youkaichao

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat

@comaniac comaniac Awaiting requested review from comaniac

@NickLucche NickLucche Awaiting requested review from NickLucche NickLucche is a code owner

@mgoin mgoin Awaiting requested review from mgoin mgoin is a code owner

@yewentao256 yewentao256 Awaiting requested review from yewentao256 yewentao256 is a code owner

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth tlrmchlsmth is a code owner

@tdoublep tdoublep Awaiting requested review from tdoublep tdoublep is a code owner

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci/build documentation Improvements or additions to documentation frontend multi-modality Related to multi-modality (#4194) qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@WoosukKwon