Skip to content

Conversation

@yaochengji
Copy link
Collaborator

@yaochengji yaochengji commented Jul 24, 2025

Purpose

Fix the tpu ci test: tests/v1/tpu/test_basic.py. In #21340, it got merged without running the TPU CI test.

Test Plan

pytest -s -v tests/v1/tpu/test_basic.py

Test Result

Passed

(Optional) Documentation Update

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added v1 tpu Related to Google TPUs labels Jul 24, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an OOM error in a TPU CI test by increasing the gpu_memory_utilization from 0.7 to 0.95. While this change may resolve the immediate issue, setting the memory utilization to such a high value introduces a risk of test flakiness and future maintenance problems. My review highlights this concern and suggests considering more robust solutions.

@yaochengji yaochengji added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 24, 2025
@vllm-bot vllm-bot merged commit 40d86ee into vllm-project:main Jul 25, 2025
55 of 57 checks passed
yaochengji added a commit that referenced this pull request Jul 25, 2025
@QiliangCui
Copy link
Contributor

This change broke the CI test again.

on main branch, one PR before this https://buildkite.com/vllm/ci/builds/24936 passed all tests.

this change caused OOM issue.

ERROR 07-25 07:24:51 [core.py:634] RuntimeError: Bad StatusOr access: RESOURCE_EXHAUSTED: Error loading program: Attempting to reserve 1.20G at the bottom of memory. That was not possible. There are 772.53M free, 0B reserved, and 772.53M reservable.

I will prepare a change to rollback this.

liuyumoye pushed a commit to liuyumoye/vllm that referenced this pull request Jul 31, 2025
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed tpu Related to Google TPUs v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants