-
-
Notifications
You must be signed in to change notification settings - Fork 11.7k
[TPU][Bugfix] fix moe layer #21340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TPU][Bugfix] fix moe layer #21340
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes a bug in the MoE layer for TPU by allowing forward_tpu to accept new arguments. It also adds a new MoE model to the TPU test suite. The fix is correct, but I've suggested an improvement to make the function signature more explicit and robust against future changes, which will improve maintainability.
Signed-off-by: Chengji Yao <[email protected]>
1d856f8 to
d8ccdaf
Compare
Signed-off-by: Chengji Yao <[email protected]>
Signed-off-by: Chengji Yao <[email protected]>
Co-authored-by: Simon Mo <[email protected]>
Signed-off-by: Chengji Yao <[email protected]> Co-authored-by: Simon Mo <[email protected]> Signed-off-by: x22x22 <[email protected]>
Signed-off-by: Chengji Yao <[email protected]> Co-authored-by: Simon Mo <[email protected]>
Signed-off-by: Chengji Yao <[email protected]> Co-authored-by: Simon Mo <[email protected]>
Signed-off-by: Chengji Yao <[email protected]> Co-authored-by: Simon Mo <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
Signed-off-by: Chengji Yao <[email protected]> Co-authored-by: Simon Mo <[email protected]> Signed-off-by: Paul Pak <[email protected]>
Signed-off-by: Chengji Yao <[email protected]> Co-authored-by: Simon Mo <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
Signed-off-by: Chengji Yao <[email protected]> Co-authored-by: Simon Mo <[email protected]>
Purpose
To fix the issue on TPU introduced by #20775, where several new arguments in moe layer are introduced, but
forward_tpudoesn't handle them.Test Plan
Test Result
Passed
(Optional) Documentation Update