Skip to content

Conversation

@yaochengji
Copy link
Collaborator

@yaochengji yaochengji commented Jul 22, 2025

Purpose

To fix the issue on TPU introduced by #20775, where several new arguments in moe layer are introduced, but forward_tpu doesn't handle them.

  • fix moe layer
  • add a TPU MoE test

Test Plan

pytest -s -v tests/v1/tpu/test_basic.py

Test Result

Passed

(Optional) Documentation Update

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@yaochengji yaochengji requested a review from mgoin July 22, 2025 00:28
@mergify mergify bot added v1 tpu Related to Google TPUs labels Jul 22, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a bug in the MoE layer for TPU by allowing forward_tpu to accept new arguments. It also adds a new MoE model to the TPU test suite. The fix is correct, but I've suggested an improvement to make the function signature more explicit and robust against future changes, which will improve maintainability.

Signed-off-by: Chengji Yao <[email protected]>
Signed-off-by: Chengji Yao <[email protected]>
Signed-off-by: Chengji Yao <[email protected]>
@yaochengji yaochengji enabled auto-merge (squash) July 24, 2025 00:43
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 24, 2025
@vllm-bot vllm-bot merged commit e74bfc7 into vllm-project:main Jul 24, 2025
73 of 76 checks passed
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
Signed-off-by: Chengji Yao <[email protected]>
Co-authored-by: Simon Mo <[email protected]>
Signed-off-by: x22x22 <[email protected]>
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
Signed-off-by: Chengji Yao <[email protected]>
Co-authored-by: Simon Mo <[email protected]>
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
Signed-off-by: Chengji Yao <[email protected]>
Co-authored-by: Simon Mo <[email protected]>
Signed-off-by: Jinzhen Lin <[email protected]>
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
Signed-off-by: Chengji Yao <[email protected]>
Co-authored-by: Simon Mo <[email protected]>
Signed-off-by: Paul Pak <[email protected]>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
Signed-off-by: Chengji Yao <[email protected]>
Co-authored-by: Simon Mo <[email protected]>
Signed-off-by: Diego-Castan <[email protected]>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed tpu Related to Google TPUs v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants