Skip to content

[BugFix] Fix ordering of KVConnector finished send/rcv sets #18211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025
Merged

[BugFix] Fix ordering of KVConnector finished send/rcv sets #18211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion vllm/distributed/kv_transfer/kv_connector/v1/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,8 @@ def get_finished(
finished generating tokens.

Returns:
ids of requests that have finished asynchronous (recving, sending).
ids of requests that have finished asynchronous transfer,
tuple of (sending/saving ids, recving/loading ids).
The finished saves/sends req ids must belong to a set provided in a
call to this method (this call or a prior one).
"""
Expand Down
6 changes: 3 additions & 3 deletions vllm/distributed/kv_transfer/kv_connector/v1/multi_connector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,10 @@ def wait_for_save(self):
def get_finished(
self, finished_req_ids: set[str]
) -> tuple[Optional[set[str]], Optional[set[str]]]:
finished_recving: set[str] = set()
finished_sending: set[str] = set()
finished_recving: set[str] = set()
for c in self._connectors:
recving, sending = c.get_finished(finished_req_ids)
sending, recving = c.get_finished(finished_req_ids)
if not recving and not sending:
continue
# Aggregate finished recving request ids.
Expand All @@ -119,7 +119,7 @@ def get_finished(
else:
self._extra_async_saves[req_id] = extra_pending - 1

return finished_recving or None, finished_sending or None
return finished_sending or None, finished_recving or None

# ==============================
# Scheduler-side methods
Expand Down