Skip to content

Conversation

@njhill
Copy link
Member

@njhill njhill commented May 15, 2025

Still pending are multi-connector tests that cover the async modes for saving/loading.

@njhill njhill added the bug Something isn't working label May 15, 2025
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@njhill njhill added the ready ONLY add when PR is ready to merge/full CI is needed label May 16, 2025
@simon-mo simon-mo merged commit 0ceaebf into vllm-project:main May 16, 2025
75 of 77 checks passed
@njhill njhill deleted the fix-send-recv-order branch May 16, 2025 16:25
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants