[Core] Don't force uppercase for VLLM_LOGGING_LEVEL #15306
Conversation
When using this env var `VLLM_LOGGING_LEVEL=debug` would result in an error. It had to be `=DEBUG`. This seems unnecessary. This change makes the code ignore the case of the env var contents by converting it with `upper()`. Signed-off-by: Russell Bryant <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
github-actions
bot
added
the
ready
| # this is used for configuring the default logging level | ||
| "VLLM_LOGGING_LEVEL": | ||
| lambda: os.getenv("VLLM_LOGGING_LEVEL", "INFO"), | ||
| lambda: os.getenv("VLLM_LOGGING_LEVEL", "INFO").upper(), |
There was a problem hiding this comment.
wondering why do we only have special handling on this env var :-)
@youkaichao, any thoughts?
There was a problem hiding this comment.
are there other logging level env vars?
Code interpreting this one expects uppercase only.
There was a problem hiding this comment.
we do have something similar:
"VLLM_USE_MODELSCOPE":
lambda: os.environ.get("VLLM_USE_MODELSCOPE", "False").lower() == "true",so this pr looks good to me.
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Wes Medford <[email protected]>
Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Louis Ulmer <[email protected]>
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Mu Huai <[email protected]>
5 participants
When using this env var
VLLM_LOGGING_LEVEL=debugwould result in anerror. It had to be
=DEBUG. This seems unnecessary. This change makesthe code ignore the case of the env var contents by converting it with
upper().Signed-off-by: Russell Bryant [email protected]