Skip to content

[CI] Fix Tool Calling Tests #14898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 17, 2025
+14 −2
Merged

[CI] Fix Tool Calling Tests #14898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6f0bfc9
updated
Mar 16, 2025
1aed6b5
stash
Mar 16, 2025
d391963
updated
Mar 16, 2025
3352db4
fixed
Mar 16, 2025
917c422
swap order
Mar 16, 2025
8a11433
stash
robertgshaw2-redhat Mar 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/models/decoder_only/language/test_mistral.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@ def test_models(
)


@pytest.mark.skip("RE-ENABLE: test is currently failing on main.")
Copy link
Collaborator Author

@robertgshaw2-redhat robertgshaw2-redhat Mar 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is failing due to an issue with the inductor cache

Copy link
Collaborator Author

@robertgshaw2-redhat robertgshaw2-redhat Mar 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @youkaichao

Copy link
Member

@youkaichao youkaichao Mar 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this error still here?

@pytest.mark.parametrize("model", MISTRAL_FORMAT_MODELS)
@pytest.mark.parametrize("dtype", ["bfloat16"])
@pytest.mark.parametrize("max_tokens", [64])
Expand Down
15 changes: 13 additions & 2 deletions tests/tool_use/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ def ensure_system_prompt(messages: list[dict[str, Any]],
"model":
"NousResearch/Hermes-3-Llama-3.1-8B",
"arguments": [
"--enforce-eager", "--no-enable-prefix-caching",
Copy link
Collaborator Author

@robertgshaw2-redhat robertgshaw2-redhat Mar 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • use --enforce-eager to make the tests faster
  • use --no-enable-prefix-caching as numerics were causing tests to fail

Copy link
Member

@russellb russellb Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue about the failure so it’s tracked somewhere? I assume we don’t want to keep this option here long term?

"--tool-call-parser", "hermes", "--chat-template",
str(VLLM_PATH / "examples/tool_chat_template_hermes.jinja")
],
Expand All @@ -60,6 +61,7 @@ def ensure_system_prompt(messages: list[dict[str, Any]],
"model":
"meta-llama/Meta-Llama-3.1-8B-Instruct",
"arguments": [
"--enforce-eager", "--no-enable-prefix-caching",
"--tool-call-parser", "llama3_json", "--chat-template",
str(VLLM_PATH / "examples/tool_chat_template_llama3.1_json.jinja")
],
Expand All @@ -70,6 +72,7 @@ def ensure_system_prompt(messages: list[dict[str, Any]],
"model":
"meta-llama/Llama-3.2-3B-Instruct",
"arguments": [
"--enforce-eager", "--no-enable-prefix-caching",
"--tool-call-parser", "llama3_json", "--chat-template",
str(VLLM_PATH / "examples/tool_chat_template_llama3.2_json.jinja")
],
Expand All @@ -80,6 +83,7 @@ def ensure_system_prompt(messages: list[dict[str, Any]],
"model":
"mistralai/Mistral-7B-Instruct-v0.3",
"arguments": [
"--enforce-eager", "--no-enable-prefix-caching",
"--tool-call-parser", "mistral", "--chat-template",
str(VLLM_PATH / "examples/tool_chat_template_mistral.jinja"),
"--ignore-patterns=\"consolidated.safetensors\""
Expand Down Expand Up @@ -111,22 +115,28 @@ def ensure_system_prompt(messages: list[dict[str, Any]],
"model":
"ibm-granite/granite-3.0-8b-instruct",
"arguments": [
"--enforce-eager", "--no-enable-prefix-caching",
"--tool-call-parser", "granite", "--chat-template",
str(VLLM_PATH / "examples/tool_chat_template_granite.jinja")
],
},
"granite-3.1-8b": {
"model": "ibm-granite/granite-3.1-8b-instruct",
"model":
"ibm-granite/granite-3.1-8b-instruct",
"arguments": [
"--enforce-eager",
"--no-enable-prefix-caching",
"--tool-call-parser",
"granite",
],
"supports_parallel": True,
"supports_parallel":
True,
},
"internlm": {
"model":
"internlm/internlm2_5-7b-chat",
"arguments": [
"--enforce-eager", "--no-enable-prefix-caching",
"--tool-call-parser", "internlm", "--chat-template",
str(VLLM_PATH /
"examples/tool_chat_template_internlm2_tool.jinja"),
Expand All @@ -139,6 +149,7 @@ def ensure_system_prompt(messages: list[dict[str, Any]],
"model":
"Team-ACE/ToolACE-8B",
"arguments": [
"--enforce-eager", "--no-enable-prefix-caching",
"--tool-call-parser", "pythonic", "--chat-template",
str(VLLM_PATH / "examples/tool_chat_template_toolace.jinja")
],
Expand Down