Skip to content

[CI] Fix Tool Calling Tests #14898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 17, 2025
Merged

[CI] Fix Tool Calling Tests #14898

merged 6 commits into from
Mar 17, 2025

Conversation

@robertgshaw2-redhat
Copy link
Collaborator

@robertgshaw2-redhat robertgshaw2-redhat commented Mar 16, 2025 •
edited by github-actions bot
Loading

SUMMARY:

  • getting nightly green

@github-actions
Copy link

github-actions bot commented Mar 16, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@robertgshaw2-redhat robertgshaw2-redhat changed the title [V1] [CI] Fix Nighly [V1] [CI] Make Nightly Green Mar 16, 2025
robertgshaw2-redhat
robertgshaw2-redhat commented Mar 16, 2025
View reviewed changes
tests/models/decoder_only/language/test_mistral.py
)


@pytest.mark.skip("RE-ENABLE: test is currently failing on main.")
Copy link
Collaborator Author

@robertgshaw2-redhat robertgshaw2-redhat Mar 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is failing due to an issue with the inductor cache

Copy link
Collaborator Author

@robertgshaw2-redhat robertgshaw2-redhat Mar 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @youkaichao

Copy link
Member

@youkaichao youkaichao Mar 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this error still here?

robertgshaw2-redhat
robertgshaw2-redhat commented Mar 16, 2025
View reviewed changes
tests/tool_use/utils.py
"model":
"NousResearch/Hermes-3-Llama-3.1-8B",
"arguments": [
"--enforce-eager", "--no-enable-prefix-caching",
Copy link
Collaborator Author

@robertgshaw2-redhat robertgshaw2-redhat Mar 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • use --enforce-eager to make the tests faster
  • use --no-enable-prefix-caching as numerics were causing tests to fail

Copy link
Member

@russellb russellb Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue about the failure so it’s tracked somewhere? I assume we don’t want to keep this option here long term?

@mergify mergify bot added the ci/build label Mar 16, 2025
@robertgshaw2-redhat robertgshaw2-redhat changed the title [V1] [CI] Make Nightly Green [CI] Make Nightly Green Mar 16, 2025
@robertgshaw2-redhat robertgshaw2-redhat changed the title [CI] Make Nightly Green [CI] Nightly Tests Mar 17, 2025
@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) March 17, 2025 00:17
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 17, 2025
russellb
russellb approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamping this since we're trying to get CI to a green state to help catch new real failures from making it in, so lgtm

@robertgshaw2-redhat robertgshaw2-redhat changed the title [CI] Nightly Tests [CI] Fix Tool Calling Tests Mar 17, 2025
@robertgshaw2-redhat robertgshaw2-redhat merged commit bb3aedd into main Mar 17, 2025
28 of 30 checks passed
@robertgshaw2-redhat robertgshaw2-redhat deleted the fix-openai-tool-calling-test branch March 17, 2025 02:06
DefTruth pushed a commit to DefTruth/vllm that referenced this pull request Mar 17, 2025
@robertgshaw2-redhat @DefTruth
[CI] Nightly Tests (vllm-project#14898)
b71f0cb 
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Co-authored-by: [email protected] <[email protected]>
Signed-off-by: DefTruth <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@robertgshaw2-redhat @lulmer
[CI] Nightly Tests (vllm-project#14898)
d1448c2 
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Co-authored-by: [email protected] <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@robertgshaw2-redhat @shreyankg
[CI] Nightly Tests (vllm-project#14898)
5a688a3 
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Co-authored-by: [email protected] <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@robertgshaw2-redhat
[CI] Nightly Tests (vllm-project#14898)
4c06636 
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Co-authored-by: [email protected] <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youkaichao youkaichao youkaichao left review comments

@russellb russellb russellb approved these changes

@DarkLight1337 DarkLight1337 Awaiting requested review from DarkLight1337 DarkLight1337 is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

Assignees

No one assigned

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@robertgshaw2-redhat @russellb @youkaichao