Skip to content

[BugFix] Fix torch distributed stateless PG backend init #14870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 16, 2025
Merged

[BugFix] Fix torch distributed stateless PG backend init #14870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a571750
[BugFix] Fix torch distributed stateless PG backend init
njhill Mar 15, 2025
8cdc714
Ensure DP test fails properly
njhill Mar 15, 2025
9bbae73
fix linting
njhill Mar 15, 2025
4c5ed2d
fix default backend call
njhill Mar 15, 2025
1a97d36
fix daemon proc in data_parallel.py
njhill Mar 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions examples/offline_inference/data_parallel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,5 +76,10 @@ def main(dp_size, dp_rank, dp_master_ip, dp_master_port, GPUs_per_dp_rank):
GPUs_per_dp_rank))
proc.start()
procs.append(proc)
exit_code = 0
for proc in procs:
proc.join()
if proc.exitcode:
exit_code = proc.exitcode

exit(exit_code)
6 changes: 3 additions & 3 deletions vllm/distributed/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,13 +299,10 @@ def stateless_init_torch_distributed_process_group(
# different systems (e.g. RPC) in case the store is multi-tenant.
prefix_store = PrefixStore(init_method, store)

pg_options = ProcessGroup.Options(backend=backend, timeout=timeout)

pg: ProcessGroup = ProcessGroup(
prefix_store,
group_rank,
group_size,
pg_options,
)

if backend == "gloo":
Expand All @@ -327,7 +324,10 @@ def stateless_init_torch_distributed_process_group(
backend_options)
backend_type = ProcessGroup.BackendType.NCCL
device = torch.device("cuda")
else:
raise RuntimeError(f"Unsupported torch distributed backend: {backend}")

pg._set_default_backend(backend_type)
backend_class._set_sequence_number_for_group()

pg._register_backend(device, backend_type, backend_class)
Expand Down