Skip to content

[BugFix] Fix torch distributed stateless PG backend init #14870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 16, 2025
Merged

[BugFix] Fix torch distributed stateless PG backend init #14870

merged 5 commits into from
Mar 16, 2025
+8 −3

Conversation

@njhill
Copy link
Member

@njhill njhill commented Mar 15, 2025 •
edited by github-actions bot
Loading

ProcessGroup.Options was removed in torch 2.5: pytorch/pytorch#132931

This affects data parallel. There was also a bug where the test script would exit successfully even if the subprocs fail, which is why we missed this originally.

@njhill
[BugFix] Fix torch distributed stateless PG backend init
a571750 
ProcessGroup.Options was removed in torch 2.6: pytorch/pytorch#132931

Signed-off-by: Nick Hill <[email protected]>
@njhill njhill added bug Something isn't working release-blocker This PR/issue blocks the next release, therefore deserves highest priority labels Mar 15, 2025
@njhill njhill added this to the v0.8.0 milestone Mar 15, 2025
@njhill njhill requested a review from youkaichao March 15, 2025 17:53
@github-actions
Copy link

github-actions bot commented Mar 15, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Mar 15, 2025
@njhill njhill marked this pull request as ready for review March 15, 2025 17:58
@njhill njhill added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 15, 2025
@njhill
fix linting
9bbae73 
Signed-off-by: Nick Hill <[email protected]>
@njhill njhill mentioned this pull request Mar 15, 2025
Merged
@simon-mo simon-mo merged commit b82662d into vllm-project:main Mar 16, 2025
35 of 37 checks passed
@njhill njhill deleted the torch-2.6-backend branch March 16, 2025 04:00
DefTruth pushed a commit to DefTruth/vllm that referenced this pull request Mar 17, 2025
@njhill @DefTruth
[BugFix] Fix torch distributed stateless PG backend init (vllm-projec…
1c59947 
…t#14870)

Signed-off-by: Nick Hill <[email protected]>
Signed-off-by: DefTruth <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@njhill @lulmer
[BugFix] Fix torch distributed stateless PG backend init (vllm-projec…
065d1fd 
…t#14870)

Signed-off-by: Nick Hill <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@njhill @shreyankg
[BugFix] Fix torch distributed stateless PG backend init (vllm-projec…
76d3a2f 
…t#14870)

Signed-off-by: Nick Hill <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@njhill
[BugFix] Fix torch distributed stateless PG backend init (vllm-projec…
ba4b752 
…t#14870)

Signed-off-by: Nick Hill <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youkaichao youkaichao Awaiting requested review from youkaichao

Assignees

No one assigned

Labels

bug Something isn't working documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed release-blocker This PR/issue blocks the next release, therefore deserves highest priority

Projects

None yet

Milestone

v0.8.0

Development

Successfully merging this pull request may close these issues.

2 participants

@njhill @simon-mo