Skip to content

Deduplicate .pre-commit-config.yaml's exclude #13967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

Deduplicate .pre-commit-config.yaml's exclude #13967

merged 1 commit into from
Feb 27, 2025
+1 −16

Conversation

@hmellor
Copy link
Member

@hmellor hmellor commented Feb 27, 2025

Replace the per repo excludes with a top level exclude

@github-actions
Copy link

github-actions bot commented Feb 27, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@Isotr0py Isotr0py enabled auto-merge (squash) February 27, 2025 14:59
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 27, 2025
@Isotr0py Isotr0py merged commit 5677c9b into vllm-project:main Feb 27, 2025
28 of 30 checks passed
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
@hmellor @Akshat-Tripathi
Deduplicate .pre-commit-config.yaml's exclude (vllm-project#13967)
e2ec2eb 
Signed-off-by: Harry Mellor <[email protected]>
@hmellor hmellor deleted the tidy-pre-commit branch March 10, 2025 10:55
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@hmellor @lulmer
Deduplicate .pre-commit-config.yaml's exclude (vllm-project#13967)
b878b67 
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@hmellor @shreyankg
Deduplicate .pre-commit-config.yaml's exclude (vllm-project#13967)
d461640 
Signed-off-by: Harry Mellor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simon-mo simon-mo simon-mo approved these changes

@Isotr0py Isotr0py Isotr0py approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hmellor @simon-mo @Isotr0py