Skip to content

Commit d461640

Browse files
hmellorshreyankg
authored andcommitted
Deduplicate .pre-commit-config.yaml's exclude (vllm-project#13967)
Signed-off-by: Harry Mellor <[email protected]>
1 parent b2ed43c commit d461640

File tree

1 file changed

+1
-16
lines changed

1 file changed

+1
-16
lines changed

.pre-commit-config.yaml

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,19 @@
11
default_stages:
22
- pre-commit # Run locally
33
- manual # Run in CI
4+
exclude: 'vllm/third_party/.*'
45
repos:
56
- repo: https://github.com/google/yapf
67
rev: v0.43.0
78
hooks:
89
- id: yapf
910
args: [--in-place, --verbose]
1011
additional_dependencies: [toml] # TODO: Remove when yapf is upgraded
11-
exclude: 'vllm/third_party/.*'
1212
- repo: https://github.com/astral-sh/ruff-pre-commit
1313
rev: v0.9.3
1414
hooks:
1515
- id: ruff
1616
args: [--output-format, github, --fix]
17-
exclude: 'vllm/third_party/.*'
1817
- repo: https://github.com/codespell-project/codespell
1918
rev: v2.4.0
2019
hooks:
@@ -25,7 +24,6 @@ repos:
2524
rev: 0a0b7a830386ba6a31c2ec8316849ae4d1b8240d # 6.0.0
2625
hooks:
2726
- id: isort
28-
exclude: 'vllm/third_party/.*'
2927
- repo: https://github.com/pre-commit/mirrors-clang-format
3028
rev: v19.1.7
3129
hooks:
@@ -38,12 +36,10 @@ repos:
3836
hooks:
3937
- id: pymarkdown
4038
args: [fix]
41-
exclude: 'vllm/third_party/.*'
4239
- repo: https://github.com/rhysd/actionlint
4340
rev: v1.7.7
4441
hooks:
4542
- id: actionlint
46-
exclude: 'vllm/third_party/.*'
4743
- repo: https://github.com/astral-sh/uv-pre-commit
4844
rev: 0.6.2
4945
hooks:
@@ -59,51 +55,44 @@ repos:
5955
types: [python]
6056
additional_dependencies: &mypy_deps [mypy==1.11.1, types-setuptools, types-PyYAML, types-requests]
6157
stages: [pre-commit] # Don't run in CI
62-
exclude: 'vllm/third_party/.*'
6358
- id: mypy-3.9 # TODO: Use https://github.com/pre-commit/mirrors-mypy when mypy setup is less awkward
6459
name: Run mypy for Python 3.9
6560
entry: tools/mypy.sh 1 "3.9"
6661
language: python
6762
types: [python]
6863
additional_dependencies: *mypy_deps
6964
stages: [manual] # Only run in CI
70-
exclude: 'vllm/third_party/.*'
7165
- id: mypy-3.10 # TODO: Use https://github.com/pre-commit/mirrors-mypy when mypy setup is less awkward
7266
name: Run mypy for Python 3.10
7367
entry: tools/mypy.sh 1 "3.10"
7468
language: python
7569
types: [python]
7670
additional_dependencies: *mypy_deps
7771
stages: [manual] # Only run in CI
78-
exclude: 'vllm/third_party/.*'
7972
- id: mypy-3.11 # TODO: Use https://github.com/pre-commit/mirrors-mypy when mypy setup is less awkward
8073
name: Run mypy for Python 3.11
8174
entry: tools/mypy.sh 1 "3.11"
8275
language: python
8376
types: [python]
8477
additional_dependencies: *mypy_deps
8578
stages: [manual] # Only run in CI
86-
exclude: 'vllm/third_party/.*'
8779
- id: mypy-3.12 # TODO: Use https://github.com/pre-commit/mirrors-mypy when mypy setup is less awkward
8880
name: Run mypy for Python 3.12
8981
entry: tools/mypy.sh 1 "3.12"
9082
language: python
9183
types: [python]
9284
additional_dependencies: *mypy_deps
9385
stages: [manual] # Only run in CI
94-
exclude: 'vllm/third_party/.*'
9586
- id: shellcheck
9687
name: Lint shell scripts
9788
entry: tools/shellcheck.sh
9889
language: script
9990
types: [shell]
100-
exclude: 'vllm/third_party/.*'
10191
- id: png-lint
10292
name: Lint PNG exports from excalidraw
10393
entry: tools/png-lint.sh
10494
language: script
10595
types: [png]
106-
exclude: 'vllm/third_party/.*'
10796
- id: signoff-commit
10897
name: Sign-off Commit
10998
entry: bash
@@ -116,13 +105,11 @@ repos:
116105
language: system
117106
verbose: true
118107
stages: [commit-msg]
119-
exclude: 'vllm/third_party/.*'
120108
- id: check-spdx-header
121109
name: Check SPDX headers
122110
entry: python tools/check_spdx_header.py
123111
language: python
124112
types: [python]
125-
exclude: 'vllm/third_party/.*'
126113
- id: check-filenames
127114
name: Check for spaces in all filenames
128115
entry: bash
@@ -132,13 +119,11 @@ repos:
132119
language: system
133120
always_run: true
134121
pass_filenames: false
135-
exclude: 'vllm/third_party/.*'
136122
# Keep `suggestion` last
137123
- id: suggestion
138124
name: Suggestion
139125
entry: bash -c 'echo "To bypass pre-commit hooks, add --no-verify to git commit."'
140126
language: system
141127
verbose: true
142128
pass_filenames: false
143-
exclude: 'vllm/third_party/.*'
144129
# Insert new entries above the `suggestion` entry

0 commit comments

Comments
 (0)