Skip to content

Conversation

@WangErXiao
Copy link
Contributor

@WangErXiao WangErXiao commented Feb 21, 2025

Fix invalid usage of 'ge' and 'le' in port validation in #13506 ,
which cause "TypeError: _StoreAction.init() got an unexpected keyword argument 'ge'".

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@Isotr0py Isotr0py enabled auto-merge (squash) February 21, 2025 14:41
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 21, 2025
auto-merge was automatically disabled February 22, 2025 00:48

Head branch was pushed to by a user without write access

@WangErXiao WangErXiao force-pushed the bugfix_for_arg_parser branch from 68c8292 to d926bc3 Compare February 22, 2025 00:48
@Isotr0py Isotr0py enabled auto-merge (squash) February 22, 2025 03:27
@simon-mo simon-mo merged commit c6ed938 into vllm-project:main Feb 22, 2025
42 of 44 checks passed
dtrifiro pushed a commit to red-hat-data-services/vllm that referenced this pull request Mar 27, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants