Skip to content

Commit 74b3937

Browse files
WangErXiaoAkshat-Tripathi
authored andcommitted
[Bugfix][API Server] Fix invalid usage of 'ge' and 'le' in port valid… (vllm-project#13672)
1 parent 3752fb3 commit 74b3937

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

vllm/entrypoints/api_server.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ async def run_server(args: Namespace,
145145
if __name__ == "__main__":
146146
parser = FlexibleArgumentParser()
147147
parser.add_argument("--host", type=str, default=None)
148-
parser.add_argument("--port", type=int, default=8000, ge=1024, le=65535)
148+
parser.add_argument("--port", type=parser.check_port, default=8000)
149149
parser.add_argument("--ssl-keyfile", type=str, default=None)
150150
parser.add_argument("--ssl-certfile", type=str, default=None)
151151
parser.add_argument("--ssl-ca-certs",

vllm/utils.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1194,6 +1194,17 @@ def parse_args(self, args=None, namespace=None):
11941194

11951195
return super().parse_args(processed_args, namespace)
11961196

1197+
def check_port(self, value):
1198+
try:
1199+
value = int(value)
1200+
except ValueError:
1201+
raise argparse.ArgumentTypeError("Port must be an integer")
1202+
1203+
if not (1024 <= value <= 65535):
1204+
raise argparse.ArgumentTypeError("Port must be between 1024 and 65535")
1205+
1206+
return value
1207+
11971208
def _pull_args_from_config(self, args: List[str]) -> List[str]:
11981209
"""Method to pull arguments specified in the config file
11991210
into the command-line args variable.

0 commit comments

Comments
 (0)